Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1109643002: Mike's radial gradient CL with better float -> int. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Mike's radial gradient CL with better float -> int. patch from issue 1072303005 at patchset 40001 (http://crrev.com/1072303005#ps40001) This looks quite launchable. radial_gradient3, min of 100 samples: N5: 985µs -> 946µs MBP: 395µs -> 279µs On my MBP, most of the meat looks like it's now in reading the cache and writing to dst one color at a time. Is that something we could do in float math rather than with a lookup table? BUG=skia: CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.8-Clang-Arm7-Debug-Android-Trybot,Build-Ubuntu-GCC-Arm7-Release-Android_NoNeon-Trybot Committed: https://skia.googlesource.com/skia/+/abf6c5cf95e921fae59efb487480e5b5081cf0ec Committed: https://skia.googlesource.com/skia/+/1113da72eced20480491bb87ade0ffcff4eb8ea7

Patch Set 1 #

Patch Set 2 : castTrunc(), Sk4i #

Patch Set 3 : NEON #

Patch Set 4 : trunc #

Patch Set 5 : SHIFT #

Patch Set 6 : tweaks #

Patch Set 7 : default #

Patch Set 8 : build fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -9 lines) Patch
M gm/gradients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkNx.h View 1 2 3 4 5 6 7 7 chunks +15 lines, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 5 chunks +80 lines, -7 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 2 3 4 5 6 7 2 chunks +44 lines, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 2 3 4 5 6 2 chunks +40 lines, -0 lines 0 comments Download
M tests/SkNxTest.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109643002/60001
5 years, 8 months ago (2015-04-25 15:17:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109643002/80001
5 years, 8 months ago (2015-04-25 18:59:58 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/662)
5 years, 8 months ago (2015-04-25 19:01:28 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109643002/100001
5 years, 8 months ago (2015-04-25 19:06:36 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109643002/120001
5 years, 8 months ago (2015-04-25 19:10:17 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109643002/120001
5 years, 8 months ago (2015-04-25 19:20:01 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-25 19:46:10 UTC) #18
mtklein_C
I'm open to landing parts first, splitting, patching this back on the original, etc.
5 years, 8 months ago (2015-04-25 19:57:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109643002/120001
5 years, 8 months ago (2015-04-27 17:37:02 UTC) #22
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-27 17:37:03 UTC) #23
reed1
lgtm
5 years, 8 months ago (2015-04-27 17:50:02 UTC) #24
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/abf6c5cf95e921fae59efb487480e5b5081cf0ec
5 years, 8 months ago (2015-04-27 18:14:01 UTC) #25
mtklein
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1109883003/ by mtklein@google.com. ...
5 years, 8 months ago (2015-04-27 18:20:49 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109643002/140001
5 years, 8 months ago (2015-04-27 18:55:45 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109643002/140001
5 years, 8 months ago (2015-04-27 19:07:53 UTC) #32
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 19:08:05 UTC) #33
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/1113da72eced20480491bb87ade0ffcff4eb8ea7

Powered by Google App Engine
This is Rietveld 408576698