Fixing all Java import ordering issues.

Fixing all Java import ordering issues.

BUG=320711
TBR=isherman@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239823

[aurimas (slooooooooow), 2013-12-10 00:20:31]

Hey Ted,

Please take a look at this change!

Aurimas

[aurimas (slooooooooow), 2013-12-10 00:24:21]

boliu@chromium.org: Please review changes in android_webview/

[Ted C, 2013-12-10 00:36:18]

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:34: import
android.webkit.WebView;
Looking at this file, android.webkit.WebView is fully qualified everywhere that
I can see.  Why are we importing this?

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
(right):

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:9:
import android.webkit.WebView;
Again, how often are these used?  If not much, let's fully qualify them instead
of adding new imports.

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java
(right):

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java:10:
import android.view.ViewConfiguration;
Same comment about imports for javadocs...applies in all subsequent files if
applicable.

https://codereview.chromium.org/110963003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/third_party/GestureDetector.java
(right):

https://codereview.chromium.org/110963003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/third_party/GestureDetector.java:32:
import android.content.Context;
hmm...this file seems odd

[boliu, 2013-12-10 00:56:09]

https://codereview.chromium.org/110963003/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java
(left):

https://codereview.chromium.org/110963003/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java:7:
import android.test.suitebuilder.annotation.SmallTest;
These two are not needed only because the test is disabled. I think we should
keep these (and subsequent ones)

[aurimas (slooooooooow), 2013-12-10 01:54:30]

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:34: import
android.webkit.WebView;
On 2013/12/10 00:36:20, Ted C wrote:
> Looking at this file, android.webkit.WebView is fully qualified everywhere
that
> I can see.  Why are we importing this?

Done.

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
(right):

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:9:
import android.webkit.WebView;
On 2013/12/10 00:36:20, Ted C wrote:
> Again, how often are these used?  If not much, let's fully qualify them
instead
> of adding new imports.

Done.

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java
(right):

https://codereview.chromium.org/110963003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java:10:
import android.view.ViewConfiguration;
On 2013/12/10 00:36:20, Ted C wrote:
> Same comment about imports for javadocs...applies in all subsequent files if
> applicable.

Done.

https://codereview.chromium.org/110963003/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java
(left):

https://codereview.chromium.org/110963003/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java:7:
import android.test.suitebuilder.annotation.SmallTest;
On 2013/12/10 00:56:10, boliu wrote:
> These two are not needed only because the test is disabled. I think we should
> keep these (and subsequent ones)

People can add back those imports when they reenabling them. I don't want to
manually go through and check which ones should be kept.

https://codereview.chromium.org/110963003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/third_party/GestureDetector.java
(right):

https://codereview.chromium.org/110963003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/third_party/GestureDetector.java:32:
import android.content.Context;
On 2013/12/10 00:36:20, Ted C wrote:
> hmm...this file seems odd

Removed changes in this file

[boliu, 2013-12-10 01:59:13]

lgtm

[Lambros, 2013-12-10 01:59:57]

remoting/ lgtm
Is there a command-line tool I can run to check these? I've tried to keep my
imports correct, but it's hard to avoid mistakes, as you can see :)

[aurimas (slooooooooow), 2013-12-10 02:01:49]

On 2013/12/10 01:59:57, Lambros wrote:
> remoting/ lgtm
> Is there a command-line tool I can run to check these? I've tried to keep my
> imports correct, but it's hard to avoid mistakes, as you can see :)

Adding a presubmit check soon: https://chromiumcodereview.appspot.com/110773002/

[aurimas (slooooooooow), 2013-12-10 02:04:03]

bulach@chromium.org: Please review changes in
base/android/*
media/base/android/*

[aurimas (slooooooooow), 2013-12-10 02:09:08]

cimamoglu@chromium.org: Please review changes in 
printing/android/

isherman@chromium.org: Please review changes in 
components/autofill/core/

yfriedman@chromium.org: Please review changes in 
net/android/
sync/android/

[Yaron, 2013-12-10 02:11:36]

lgtm

In general this is easier (i.e. less chances of merge conflicts) if you break up
by package

[bulach, 2013-12-10 09:55:17]

lgtm for base/android/*, +qinmin for media/base/android/*

thanks!! agreed your life would be easier with this being split by module..

also: presubmit hooks are nice, but is there any chance of making a command line
auto-formatter? not everybody uses eclipse, and it'd be nice to have one script
that developers can decide to run if/when they want to automatically fix such
mistakes.. wdyt?

[cimamoglu1, 2013-12-10 10:31:16]

lgtm

https://chromiumcodereview.appspot.com/110963003/diff/40001/printing/android/...
File printing/android/java/src/org/chromium/printing/PrintingController.java
(right):

https://chromiumcodereview.appspot.com/110963003/diff/40001/printing/android/...
printing/android/java/src/org/chromium/printing/PrintingController.java:7:
import android.print.PrintDocumentAdapter;
Is this required? I mean, it is only referenced in javadoc. I made a quick
search, and people seem to be divided on the issue. WDYT?

[tfarina, 2013-12-10 15:30:08]

As you can see from
https://github.com/dburger/bin/blob/f925d3c7145710c9708e37c7b852f9d8dcb60dbf/...,
google3 already has a python tool to do this. Can you look there and see if you
can port it to chromium?

[Ted C, 2013-12-10 17:26:29]

lgtm

[qinmin, 2013-12-10 17:29:22]

lgtm

[cimamoglu (inactive), 2013-12-10 17:49:21]

lgtm

[commit-bot: I haz the power, 2013-12-10 18:47:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/110963003/70001

[commit-bot: I haz the power, 2013-12-10 18:48:21]

Failed to apply patch for
android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
  Hunk #1 FAILED at 8.
  1 out of 1 hunk FAILED -- saving rejects to file
android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java.rej

Patch:      
android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
Index:
android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
diff --git
a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
index
f283b2dc1f54a176abb65a5a9f8dcc995cbb49a7..024c9fffed568cfa3c1cf06cef350a36c8f84ccb
100644
---
a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
+++
b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
@@ -8,16 +8,15 @@ import android.test.suitebuilder.annotation.SmallTest;
 
 import org.apache.http.Header;
 import org.apache.http.HttpRequest;
-
 import org.chromium.android_webview.AwContents;
 import org.chromium.base.test.util.Feature;
 import org.chromium.content.browser.LoadUrlParams;
 import org.chromium.content.browser.test.util.CallbackHelper;
 import org.chromium.net.test.util.TestWebServer;
 
-import java.util.concurrent.TimeUnit;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.concurrent.TimeUnit;
 
 /**
  * Test suite for loadUrl().

[commit-bot: I haz the power, 2013-12-10 18:51:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/110963003/90001

[commit-bot: I haz the power, 2013-12-10 19:15:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/110963003/110001

[commit-bot: I haz the power, 2013-12-10 19:28:20]

Change committed as 239823

[Ilya Sherman, 2013-12-10 20:45:26]

//components/autofill lgtm