Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: win8/metro_driver/chrome_app_view.cc

Issue 11096013: Add functionality to the Windows 8 notification display functionality to invoke a caller specified … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: win8/metro_driver/chrome_app_view.cc
===================================================================
--- win8/metro_driver/chrome_app_view.cc (revision 160674)
+++ win8/metro_driver/chrome_app_view.cc (working copy)
@@ -519,7 +519,9 @@
void DisplayNotification(const char* origin_url, const char* icon_url,
const wchar_t* title, const wchar_t* body,
const wchar_t* display_source,
- const char* notification_id) {
+ const char* notification_id,
+ base::win::MetroNotificationClickedHandler handler,
+ const wchar_t* handler_context) {
// TODO(ananta)
// Needs implementation.
DVLOG(1) << __FUNCTION__;
@@ -529,7 +531,9 @@
title,
body,
display_source,
- notification_id);
+ notification_id,
+ handler,
+ handler_context);
globals.appview_msg_loop->PostTask(
FROM_HERE, base::Bind(&ChromeAppView::DisplayNotification,
globals.view, notification));
@@ -843,6 +847,7 @@
options.message_loop_type = MessageLoop::TYPE_IO;
thread.StartWithOptions(options);
+#if defined(USE_AURA)
robertshield 2012/10/09 21:17:14 Why is this #if here?
ananta 2012/10/09 21:20:53 This code is specific to AURA. Will remove it if y
robertshield 2012/10/09 21:44:57 It's ok to leave it, but please add a brief commen
ananta 2012/10/09 21:58:34 Done.
ChromeChannelListener channel_listener;
IPC::ChannelProxy chan("viewer", IPC::Channel::MODE_NAMED_CLIENT,
&channel_listener, thread.message_loop_proxy());
@@ -851,7 +856,7 @@
gfx::NativeViewId(globals.core_window)));
DVLOG(1) << "ICoreWindow sent " << globals.core_window;
-
+#endif
// And post the task that'll do the inner Metro message pumping to it.
msg_loop.PostTask(FROM_HERE, base::Bind(&RunMessageLoop, dispatcher.Get()));

Powered by Google App Engine
This is Rietveld 408576698