Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 1109593002: SkTime: return timezone information (Closed)

Created:
5 years, 8 months ago by hal.canary
Modified:
5 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkTime: return timezone information; format in ISO-8601 Motivation: PDF/A metadata will need the creation date embedded in it. Also, GetDateTime returns local time in Win32. This now behaves the same as on Unix systems. BUG=skia:3110 Committed: https://skia.googlesource.com/skia/+/0b9d4118ba4f3f1190c063492894e324c63e8fd8

Patch Set 1 #

Patch Set 2 : 2015-04-24 (Friday) 17:05:34 EDT #

Patch Set 3 : 2015-04-24 (Friday) 17:09:06 EDT #

Patch Set 4 : verification code #

Total comments: 4

Patch Set 5 : 2015-04-27 (Monday) 22:34:51 EDT #

Patch Set 6 : reorder assignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M gyp/core.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkTime.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
A src/core/SkTime.cpp View 1 2 3 4 1 chunk +24 lines, -0 lines 0 comments Download
M src/ports/SkTime_Unix.cpp View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkTime_win.cpp View 1 2 3 4 5 1 chunk +16 lines, -2 lines 0 comments Download
M tests/Time.cpp View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109593002/20001
5 years, 8 months ago (2015-04-24 21:03:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109593002/40001
5 years, 8 months ago (2015-04-24 21:06:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109593002/60001
5 years, 8 months ago (2015-04-24 21:09:30 UTC) #7
hal.canary
PTAL
5 years, 8 months ago (2015-04-24 21:13:27 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-24 21:14:37 UTC) #11
reed1
https://codereview.chromium.org/1109593002/diff/80001/include/core/SkTime.h File include/core/SkTime.h (right): https://codereview.chromium.org/1109593002/diff/80001/include/core/SkTime.h#newcode30 include/core/SkTime.h:30: int16_t fTimeZoneMinutes; // The number of minutes that GetDateTime() ...
5 years, 8 months ago (2015-04-27 20:49:11 UTC) #12
hal.canary
https://codereview.chromium.org/1109593002/diff/80001/include/core/SkTime.h File include/core/SkTime.h (right): https://codereview.chromium.org/1109593002/diff/80001/include/core/SkTime.h#newcode30 include/core/SkTime.h:30: int16_t fTimeZoneMinutes; // The number of minutes that GetDateTime() ...
5 years, 8 months ago (2015-04-28 02:35:30 UTC) #13
hal.canary
ping
5 years, 7 months ago (2015-05-01 11:47:19 UTC) #14
reed1
lgtm w/ nit : we assign the new field last, but it is stored first ...
5 years, 7 months ago (2015-05-01 12:56:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109593002/120001
5 years, 7 months ago (2015-05-01 14:02:12 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 14:06:29 UTC) #19
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://skia.googlesource.com/skia/+/0b9d4118ba4f3f1190c063492894e324c63e8fd8

Powered by Google App Engine
This is Rietveld 408576698