extensions/browser/extension_function_histogram_value.h - Issue 1109563003: Implement remaining chrome.searchEnginesPrivate methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function_histogram_value.h

Issue 1109563003: Implement remaining chrome.searchEnginesPrivate methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Steven's comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/search_engines_private/search_engines_private_api.cc ('K') | « chrome/test/data/extensions/api_test/search_engines_private/test.js ('k') | third_party/closure_compiler/externs/search_engines_private.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function_histogram_value.h

diff --git a/extensions/browser/extension_function_histogram_value.h b/extensions/browser/extension_function_histogram_value.h

index e5fe08b3254c67782961c0b74d80d20dea10281f..d3fce368c30317c68420a7786ce02a09bf1db519 100644

--- a/extensions/browser/extension_function_histogram_value.h

+++ b/extensions/browser/extension_function_histogram_value.h

@@ -1069,7 +1069,7 @@ enum HistogramValue {

DEVELOPERPRIVATE_SHOWPATH,

FILEMANAGERPRIVATE_ADDPROVIDEDFILESYSTEM,

FILEMANAGERPRIVATE_CONFIGUREPROVIDEDFILESYSTEM,

- SEARCHENGINESPRIVATE_GETDEFAULTSEARCHENGINES,

+ SEARCHENGINESPRIVATE_GETSEARCHENGINES,

Mark P 2015/04/29 18:00:19 Does this function do something different than it

stevenjb 2015/04/29 18:16:08 This is a private API that is in development and h

SEARCHENGINESPRIVATE_SETSELECTEDSEARCHENGINE,

AUTOFILLPRIVATE_SAVEADDRESS,

AUTOFILLPRIVATE_GETADDRESSCOMPONENTS,

@@ -1082,6 +1082,11 @@ enum HistogramValue {

INSTANCEID_GETTOKEN,

INSTANCEID_DELETETOKEN,

INSTANCEID_DELETEID,

+ SEARCHENGINESPRIVATE_GETHOTWORDSTATE,

+ SEARCHENGINESPRIVATE_ADDOTHERSEARCHENGINE,

+ SEARCHENGINESPRIVATE_REMOVESEARCHENGINE,

+ SEARCHENGINESPRIVATE_UPDATESEARCHENGINE,

+ SEARCHENGINESPRIVATE_OPTINTOHOTWORDING,

// Last entry: Add new entries above and ensure to update

// tools/metrics/histograms/histograms.xml.

ENUM_BOUNDARY