Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1109533003: Exclude the HarfBuzz tests instead of suppressing them. (Closed)

Created:
5 years, 8 months ago by Jeffrey Yasskin
Modified:
5 years, 8 months ago
Reviewers:
eae
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude the HarfBuzz tests instead of suppressing them. The out-of-bounds access leads to a test failure under DrMemory. BUG=480650 TBR=eae@chromium.org Committed: https://crrev.com/c93a3a35172670290cecc39327152d1f73588997 Cr-Commit-Position: refs/heads/master@{#326888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +0 lines, -7 lines 0 comments Download
A tools/valgrind/gtest_exclude/blink_platform_unittests.gtest_win32.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109533003/1
5 years, 8 months ago (2015-04-24 21:25:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 21:51:24 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:52:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c93a3a35172670290cecc39327152d1f73588997
Cr-Commit-Position: refs/heads/master@{#326888}

Powered by Google App Engine
This is Rietveld 408576698