Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1109523002: Use the variable "branding_path_component" to locate brand-specific files and resources in installer (Closed)

Created:
5 years, 8 months ago by gburanov
Modified:
5 years, 8 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, robertshield, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the variable "branding_path_component" to locate brand-specific files and resources in installer gyp files. Please take look at https://codereview.chromium.org/1090213002/patch/40001/50001 for details BUG= Committed: https://crrev.com/b8313d33f695cb4dd76214afef738ddb252fcfae Cr-Commit-Position: refs/heads/master@{#327042}

Patch Set 1 #

Patch Set 2 : continue simplify branding #

Patch Set 3 : Fix build broken by previous commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -57 lines) Patch
M chrome/installer/installer_tools.gyp View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 2 3 chunks +1 line, -28 lines 0 comments Download
M chrome/installer/mini_installer_syzygy.gyp View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/installer/upgrade_test.gyp View 1 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
gburanov
5 years, 8 months ago (2015-04-24 12:14:48 UTC) #2
grt (UTC plus 2)
I've moved robertshield and gab to the CC line. Please do not spam all OWNERS ...
5 years, 8 months ago (2015-04-24 14:20:03 UTC) #4
gburanov
On 2015/04/24 14:20:03, grt wrote: > I've moved robertshield and gab to the CC line. ...
5 years, 8 months ago (2015-04-24 14:24:44 UTC) #5
grt (UTC plus 2)
On 2015/04/24 14:20:03, grt wrote: > I've moved robertshield and gab to the CC line. ...
5 years, 8 months ago (2015-04-24 14:25:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109523002/40001
5 years, 8 months ago (2015-04-27 09:33:10 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-27 09:33:12 UTC) #10
gburanov
> When writing descriptions for your CLs, please take a moment to think about what ...
5 years, 8 months ago (2015-04-27 09:34:40 UTC) #11
grt (UTC plus 2)
lgtm. see http://www.chromium.org/getting-involved/become-a-committer#TOC-Try-job-access for try job access.
5 years, 8 months ago (2015-04-27 14:19:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109523002/40001
5 years, 8 months ago (2015-04-27 14:19:41 UTC) #14
gburanov
On 2015/04/27 14:19:33, grt wrote: > lgtm. > > see > http://www.chromium.org/getting-involved/become-a-committer#TOC-Try-job-access > for try ...
5 years, 8 months ago (2015-04-27 14:42:01 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-27 14:42:16 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:43:09 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b8313d33f695cb4dd76214afef738ddb252fcfae
Cr-Commit-Position: refs/heads/master@{#327042}

Powered by Google App Engine
This is Rietveld 408576698