compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 11095003: Issue 5719. There are no warning for operator-() and numberic return anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 11095003: Issue 5719. There are no warning for operator-() and numberic return anymore. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index 1528a11f6b0109fdba4b29e68d201d4eaba47418..28ebdb486e6366ebd4334f13acbc513117972c64 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -2046,14 +2046,6 @@ public class TypeAnalyzer implements DartCompilationPhase {

}

- // operator "negate" should return numeric type

- if (modifiers.isOperator() && methodElement.getName().equals("-")

- && methodElement.getParameters().isEmpty() && returnTypeNode != null) {

- Type returnType = node.getElement().getFunctionType().getReturnType();

- if (!types.isSubtype(returnType, numType)) {

- typeError(returnTypeNode, TypeErrorCode.OPERATOR_NEGATE_NUM_RETURN_TYPE);

- }

// operator "[]=" should return void

if (modifiers.isOperator() && methodElement.getName().equals("[]=")

&& returnTypeNode != null) {