Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1109493005: Extract http_server.py from android.py. (Closed)

Created:
5 years, 8 months ago by ppi
Modified:
5 years, 8 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, ppi+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix a typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -129 lines) Patch
M mojo/devtools/common/pylib/android.py View 1 4 chunks +4 lines, -129 lines 0 comments Download
A mojo/devtools/common/pylib/http_server.py View 1 2 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Ben, ptal.
5 years, 8 months ago (2015-04-24 17:05:30 UTC) #2
qsr
lgtm
5 years, 8 months ago (2015-04-27 07:46:00 UTC) #3
ppi
5 years, 8 months ago (2015-04-27 09:16:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
542f94c289ab6e10aac7912ae02255a35de10b7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698