[MacViews] Fix behavior of non-resizable windows in fullscreen.

ui/views/cocoa/views_nswindow_delegate.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/views_nswindow_delegate.h"
 
 #include "base/logging.h"
 #import "ui/views/cocoa/bridged_content_view.h"
 #import "ui/views/cocoa/bridged_native_widget.h"
 #include "ui/views/widget/native_widget_mac.h"
@@ skipping 98 matching lines @@
 }
 
 - (void)windowWillExitFullScreen:(NSNotification*)notification {
   parent_->OnFullscreenTransitionStart(false);
 }
 
 - (void)windowDidExitFullScreen:(NSNotification*)notification {
   parent_->OnFullscreenTransitionComplete(false);
 }
 
+// Allow non-resizable windows (without NSResizableWindowMask) to enter
+// fullscreen by passing through the full size in willUseFullScreenContentSize.
+// This only happens when -[NSWindow toggleFullscreen:] is called since
+// non-resizable windows have no fullscreen button.
+- (NSSize)window:(NSWindow*)window
+    willUseFullScreenContentSize:(NSSize)proposedSize {

[tapted, 2015/05/06 06:20:41]

Can you explain this change?

And, e.g., could we instead make non-resizable windows resizable while they are
fullscreen?
and why can't non-resizable windows occupy only their fixed size while in a
fullscreen desktop? (i.e. is this just to preserve the current behaviour of
packaged apps?)

[jackhou1, 2015/05/13 04:27:53]

Yes (and doing the same with size constraints). But changing the resizable mask
causes OnSizeConstraintsChanged to be recursively called:

2   Chromium Framework                  0x0000000111734e9d
gfx::ApplyNSWindowSizeConstraints(NSWindow*, gfx::Size const&, gfx::Size const&,
bool, bool) + 429
3   Chromium Framework                  0x00000001198af6bf
views::BridgedNativeWidget::OnSizeConstraintsChanged() + 127
4   Chromium Framework                  0x00000001199b89a2
views::NativeWidgetMac::OnSizeConstraintsChanged() + 50
5   Chromium Framework                  0x00000001199b8902
views::NativeWidgetMac::OnRootViewLayout() + 50
6   Chromium Framework                  0x00000001199c74d6
views::Widget::OnRootViewLayout() + 54
7   Chromium Framework                  0x00000001199bce7a
views::internal::RootView::Layout() + 58
8   Chromium Framework                  0x0000000119999718
views::View::BoundsChanged(gfx::Rect const&) + 776
9   Chromium Framework                  0x0000000119999325
views::View::SetBoundsRect(gfx::Rect const&) + 261
10  Chromium Framework                  0x00000001199991f0
views::View::SetBounds(int, int, int, int) + 144
11  Chromium Framework                  0x0000000119999897
views::View::SetSize(gfx::Size const&) + 103
12  Chromium Framework                  0x00000001198a8085 -[BridgedContentView
setFrameSize:] + 501
13  AppKit                              0x00007fff876ec090 -[NSWindow
_oldPlaceWindow:] + 1627
14  AppKit                              0x00007fff876eb3aa -[NSWindow
_setFrameCommon:display:stashSize:] + 2527
15  AppKit                              0x00007fff878484cc __25-[NSWindow
setStyleMask:]_block_invoke + 2142
16  AppKit                              0x00007fff876f36b3
NSPerformWithScreenUpdatesDisabled + 65
17  AppKit                              0x00007fff87847c20 -[NSWindow
setStyleMask:] + 222

So to prevent it being changed back, I made
BridgedNativeWidget::ToggleDesiredFullscreenState set target_fullscreen_state_.
WDYT?
Yup, should this be different for non-app windows?

+  return proposedSize;
+}
+
 @end