[MacViews] Fix behavior of non-resizable windows in fullscreen.

ui/views/cocoa/bridged_native_widget.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_native_widget.h"
 
 #import <objc/runtime.h>
 
 #include "base/logging.h"
 #include "base/mac/mac_util.h"
@@ skipping 412 matching lines @@
   // of relying on AppKit to do it, and not worry that OnVisibilityChanged()
   // won't be called for externally triggered fullscreen requests.
   if (!window_visible_)
     SetVisibilityState(SHOW_INACTIVE);
 
   if (base::mac::IsOSSnowLeopard()) {
     NOTIMPLEMENTED();
     return;  // TODO(tapted): Implement this for Snow Leopard.
   }
 
-  // Since fullscreen requests are ignored if the collection behavior does not
-  // allow it, save the collection behavior and restore it after.
-  NSWindowCollectionBehavior behavior = [window_ collectionBehavior];
-  [window_ setCollectionBehavior:behavior |
-                                 NSWindowCollectionBehaviorFullScreenPrimary];
+  // Enable fullscreen collection behavior because:
+  // 1: -[NSWindow toggleFullscreen:] would otherwise be ignored,
+  // 2: the fullscreen button must be enabled so the user can leave fullscreen.
+  gfx::SetNSWindowCanFullscreen(window_, true);

[tapted, 2015/05/06 06:20:41]

Why always `true`? (this function is a toggle).

i.e. when coming out of fullscreen, what hides the button?

[jackhou1, 2015/05/13 04:27:53]

Changed to only set the collection behavior if not already fullscreen. It also
removes size constraints now.

   [window_ toggleFullScreen:nil];
-  [window_ setCollectionBehavior:behavior];
 }
 
 void BridgedNativeWidget::OnSizeChanged() {
   gfx::Size new_size = GetClientAreaSize();
   native_widget_mac_->GetWidget()->OnNativeWidgetSizeChanged(new_size);
   if (layer())
     UpdateLayerProperties();
 }
 
 void BridgedNativeWidget::OnVisibilityChanged() {
@@ skipping 71 matching lines @@
 }
 
 void BridgedNativeWidget::OnSizeConstraintsChanged() {
   NSWindow* window = ns_window();
   Widget* widget = native_widget_mac()->GetWidget();
   gfx::Size min_size = widget->GetMinimumSize();
   gfx::Size max_size = widget->GetMaximumSize();
   bool is_resizable = widget->widget_delegate()->CanResize();
   bool shows_resize_controls =
       is_resizable && (min_size.IsEmpty() || min_size != max_size);
-  bool shows_fullscreen_controls =
-      is_resizable && widget->widget_delegate()->CanMaximize();
+  // Fullscreen controls should be enabled when in fullscreen so the user can
+  // leave.
+  bool shows_fullscreen_controls = target_fullscreen_state_ ||

[tapted, 2015/05/06 06:20:41]

What will call OnSizeConstraintsChanged() when target_fullscreen_state_ changes?

Maybe call OnSizeConstraintsChanged() unconditionally from
OnFullscreenTransitionComplete(), and update the comment in
ToggleDesiredFullscreenState to mention that the flag will be cleared once the
animation completes

[jackhou1, 2015/05/13 04:27:53]

There's a RootView::Layout after leaving fullscreen:

2   Chromium Framework                  0x0000000113502ab0
views::BridgedNativeWidget::OnSizeConstraintsChanged() + 208
3   Chromium Framework                  0x000000011360a9a2
views::NativeWidgetMac::OnSizeConstraintsChanged() + 50
4   Chromium Framework                  0x000000011360a902
views::NativeWidgetMac::OnRootViewLayout() + 50
5   Chromium Framework                  0x00000001136194d6
views::Widget::OnRootViewLayout() + 54
6   Chromium Framework                  0x000000011360ee7a
views::internal::RootView::Layout() + 58
7   Chromium Framework                  0x00000001135eb718
views::View::BoundsChanged(gfx::Rect const&) + 776
8   Chromium Framework                  0x00000001135eb325
views::View::SetBoundsRect(gfx::Rect const&) + 261
9   Chromium Framework                  0x00000001135eb1f0
views::View::SetBounds(int, int, int, int) + 144
10  Chromium Framework                  0x00000001135eb897
views::View::SetSize(gfx::Size const&) + 103
11  Chromium Framework                  0x00000001134f9d85 -[BridgedContentView
setFrameSize:] + 501
12  AppKit                              0x00007fff876ec090 -[NSWindow
_oldPlaceWindow:] + 1627
13  AppKit                              0x00007fff876eb3aa -[NSWindow
_setFrameCommon:display:stashSize:] + 2527
14  AppKit                              0x00007fff87e7df1c
-[_NSWindowFullScreenTransition setTransitionedWindowFrame:] + 84
15  AppKit                              0x00007fff878a2152
-[_NSWindowFullScreenTransition exitFullScreenTransitionForWindow:animated:] +
799
16  AppKit                              0x00007fff878a1d53 -[NSWindow
_resignFullScreenWindowAndExitFullScreen:] + 103
Done.

+      (is_resizable && widget->widget_delegate()->CanMaximize());
 
   gfx::ApplyNSWindowSizeConstraints(window, min_size, max_size,
                                     shows_resize_controls,
                                     shows_fullscreen_controls);
 }
 
 InputMethod* BridgedNativeWidget::CreateInputMethod() {
   if (switches::IsTextInputFocusManagerEnabled())
     return new NullInputMethod();
 
@@ skipping 289 matching lines @@
       window_, &kWindowPropertiesKey);
   if (!properties) {
     properties = [NSMutableDictionary dictionary];
     objc_setAssociatedObject(window_, &kWindowPropertiesKey,
                              properties, OBJC_ASSOCIATION_RETAIN);
   }
   return properties;
 }
 
 }  // namespace views