Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: components/devtools_discovery/basic_target_descriptor.h

Issue 1109483003: [DevTools] Migrate chrome to devtools_discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devtools-discovery-android
Patch Set: rebased Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_debugger.gypi ('k') | components/devtools_discovery/basic_target_descriptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/devtools_discovery/basic_target_descriptor.h
diff --git a/components/devtools_discovery/basic_target_descriptor.h b/components/devtools_discovery/basic_target_descriptor.h
index 9072e0f5c7f943c9c5c0e539e9649895294004a2..a3b834a7e3ad0747d303468db03fb082b26a8a1e 100644
--- a/components/devtools_discovery/basic_target_descriptor.h
+++ b/components/devtools_discovery/basic_target_descriptor.h
@@ -34,8 +34,21 @@ class BasicTargetDescriptor : public DevToolsTargetDescriptor {
bool Activate() const override;
bool Close() const override;
+ protected:
+ void set_parent_id(const std::string& parent_id) { parent_id_ = parent_id; }
+ void set_type(const std::string& type) { type_ = type; }
+ void set_title(const std::string& title) { title_ = title; }
+ void set_description(const std::string& desc) { description_ = desc; }
+ void set_url(const GURL& url) { url_ = url; }
+ void set_favicon_url(const GURL& url) { favicon_url_ = url; }
+
private:
scoped_refptr<content::DevToolsAgentHost> agent_host_;
+ std::string parent_id_;
+ std::string type_;
+ std::string title_;
+ std::string description_;
+ GURL url_;
GURL favicon_url_;
base::TimeTicks last_activity_time_;
};
« no previous file with comments | « chrome/chrome_debugger.gypi ('k') | components/devtools_discovery/basic_target_descriptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698