Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1109483003: [DevTools] Migrate chrome to devtools_discovery. (Closed)

Created:
5 years, 8 months ago by dgozman
Modified:
5 years, 7 months ago
CC:
aandrey+blink_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, pfeldman, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@devtools-discovery-android
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate chrome to devtools_discovery. BUG=476496 Committed: https://crrev.com/cb088d0b50d0dcc1a7ac0b431d10829ef426e369 Cr-Commit-Position: refs/heads/master@{#327267}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -166 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/devtools/chrome_devtools_discovery_provider.h View 1 chunk +7 lines, -7 lines 0 comments Download
A chrome/browser/devtools/chrome_devtools_discovery_provider.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.h View 3 chunks +8 lines, -47 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.cc View 9 chunks +10 lines, -76 lines 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/chrome_debugger.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/devtools_discovery/basic_target_descriptor.h View 1 chunk +13 lines, -0 lines 0 comments Download
M components/devtools_discovery/basic_target_descriptor.cc View 2 chunks +27 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dgozman
Could you please take a look? This is a last migration patch. Next one will ...
5 years, 8 months ago (2015-04-24 12:02:30 UTC) #2
pfeldman
lgtm
5 years, 8 months ago (2015-04-24 12:56:34 UTC) #3
dgozman
@jochen: take a look at c/b/chrome_browser_main.cc please.
5 years, 8 months ago (2015-04-27 11:44:34 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-27 19:39:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109483003/20001
5 years, 7 months ago (2015-04-28 10:39:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 11:57:54 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 11:58:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb088d0b50d0dcc1a7ac0b431d10829ef426e369
Cr-Commit-Position: refs/heads/master@{#327267}

Powered by Google App Engine
This is Rietveld 408576698