Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1109473004: gpu: Fix some problems reported by 'gn check'.

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Fix some problems reported by 'gn check'. Tested on Linux with the following command lines: $ gn gen out-gn $ gn check //gpu/* BUG=367595, 376000 TEST=see above R=sievers@chromium.org

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
5 years, 8 months ago (2015-04-24 23:44:58 UTC) #1
no sievers
https://codereview.chromium.org/1109473004/diff/1/gpu/command_buffer/service/BUILD.gn File gpu/command_buffer/service/BUILD.gn (right): https://codereview.chromium.org/1109473004/diff/1/gpu/command_buffer/service/BUILD.gn#newcode152 gpu/command_buffer/service/BUILD.gn:152: "//gpu/command_buffer/client:client_sources", wait, service_sources shouldn't depend on client_sources. why is ...
5 years, 8 months ago (2015-04-27 19:30:46 UTC) #2
tfarina
https://codereview.chromium.org/1109473004/diff/1/gpu/command_buffer/service/BUILD.gn File gpu/command_buffer/service/BUILD.gn (right): https://codereview.chromium.org/1109473004/diff/1/gpu/command_buffer/service/BUILD.gn#newcode152 gpu/command_buffer/service/BUILD.gn:152: "//gpu/command_buffer/client:client_sources", On 2015/04/27 19:30:46, sievers wrote: > wait, service_sources ...
5 years, 8 months ago (2015-04-27 19:33:56 UTC) #3
no sievers
On 2015/04/27 19:33:56, tfarina wrote: > https://codereview.chromium.org/1109473004/diff/1/gpu/command_buffer/service/BUILD.gn > File gpu/command_buffer/service/BUILD.gn (right): > > https://codereview.chromium.org/1109473004/diff/1/gpu/command_buffer/service/BUILD.gn#newcode152 > ...
5 years, 8 months ago (2015-04-27 19:42:57 UTC) #4
tfarina
5 years, 7 months ago (2015-05-04 17:55:27 UTC) #5 
On 2015/04/27 19:42:57, sievers wrote:
> On 2015/04/27 19:33:56, tfarina wrote:
> >
>
https://codereview.chromium.org/1109473004/diff/1/gpu/command_buffer/service/...
> > File gpu/command_buffer/service/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/1109473004/diff/1/gpu/command_buffer/service/...
> > gpu/command_buffer/service/BUILD.gn:152:
> > "//gpu/command_buffer/client:client_sources",
> > On 2015/04/27 19:30:46, sievers wrote:
> > > wait, service_sources shouldn't depend on client_sources. why is that
> needed?
> > 
> > Because gpu/command_buffer/service is including from it:
> > gpu/command_buffer/client/gpu_memory_buffer_manager.h,
> > gpu/command_buffer/client/gpu_control.h
> 
> Uh this sucks. Can you file a bug?
Done. https://code.google.com/p/chromium/issues/detail?id=484284

Powered by Google App Engine
This is Rietveld 408576698