Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 110943003: MIPS: Properly restore the receiver after the interceptor call. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1060 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 1071
1072 void LoadWithInterceptor(MacroAssembler* masm, 1072 void LoadWithInterceptor(MacroAssembler* masm,
1073 Register receiver, 1073 Register receiver,
1074 Register holder, 1074 Register holder,
1075 Handle<JSObject> holder_obj, 1075 Handle<JSObject> holder_obj,
1076 Register scratch, 1076 Register scratch,
1077 Label* interceptor_succeeded) { 1077 Label* interceptor_succeeded) {
1078 { 1078 {
1079 FrameScope scope(masm, StackFrame::INTERNAL); 1079 FrameScope scope(masm, StackFrame::INTERNAL);
1080 1080
1081 __ Push(holder, name_); 1081 __ Push(receiver, holder, name_);
1082 CompileCallLoadPropertyWithInterceptor( 1082 CompileCallLoadPropertyWithInterceptor(
1083 masm, receiver, holder, name_, holder_obj, 1083 masm, receiver, holder, name_, holder_obj,
1084 IC::kLoadPropertyWithInterceptorOnly); 1084 IC::kLoadPropertyWithInterceptorOnly);
1085 __ pop(name_); // Restore the name. 1085 __ pop(receiver);
1086 __ pop(holder); // Restore the holder. 1086 __ pop(name_);
1087 __ pop(holder);
1087 } 1088 }
1088 // If interceptor returns no-result sentinel, call the constant function. 1089 // If interceptor returns no-result sentinel, call the constant function.
1089 __ LoadRoot(scratch, Heap::kNoInterceptorResultSentinelRootIndex); 1090 __ LoadRoot(scratch, Heap::kNoInterceptorResultSentinelRootIndex);
1090 __ Branch(interceptor_succeeded, ne, v0, Operand(scratch)); 1091 __ Branch(interceptor_succeeded, ne, v0, Operand(scratch));
1091 } 1092 }
1092 1093
1093 CallStubCompiler* stub_compiler_; 1094 CallStubCompiler* stub_compiler_;
1094 const ParameterCount& arguments_; 1095 const ParameterCount& arguments_;
1095 Register name_; 1096 Register name_;
1096 }; 1097 };
(...skipping 1785 matching lines...) Expand 10 before | Expand all | Expand 10 after
2882 // ----------------------------------- 2883 // -----------------------------------
2883 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 2884 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
2884 } 2885 }
2885 2886
2886 2887
2887 #undef __ 2888 #undef __
2888 2889
2889 } } // namespace v8::internal 2890 } } // namespace v8::internal
2890 2891
2891 #endif // V8_TARGET_ARCH_MIPS 2892 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698