Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Unified Diff: base/win/scoped_handle.cc

Issue 1109423003: Revert of Conv CHECK->DCHECK in CloseHandle (top crasher & data enough to debug) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/scoped_handle.cc
diff --git a/base/win/scoped_handle.cc b/base/win/scoped_handle.cc
index 034f6a71ee066c2f96dff8a0b9ecd3fe0d112587..33a8aa5c743b7b27eab6349fa1f0ee953dca6909 100644
--- a/base/win/scoped_handle.cc
+++ b/base/win/scoped_handle.cc
@@ -40,11 +40,9 @@
base::LazyInstance<NativeLock>::Leaky g_lock = LAZY_INSTANCE_INITIALIZER;
bool CloseHandleWrapper(HANDLE handle) {
- if (::CloseHandle(handle))
- return true;
-
- NOTREACHED();
- return false;
+ if (!::CloseHandle(handle))
+ CHECK(false);
+ return true;
}
// Simple automatic locking using a native critical section so it supports
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698