Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1109423003: Revert of Conv CHECK->DCHECK in CloseHandle (top crasher & data enough to debug) (Closed)

Created:
5 years, 7 months ago by grt (UTC plus 2)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Conv CHECK->DCHECK in CloseHandle (top crasher & data enough to debug) (patchset #2 id:20001 of https://codereview.chromium.org/1108953003/) Reason for revert: rvargas said so. Original issue's description: > Conv CHECK->DCHECK in CloseHandle (top crasher & data enough to debug) > We seem to have gathered enough data to find out debug further cause/reason for calling CloseHandle on already closed/invalid handle. > There are couple of theories which need to be investigated further like policy ownership of TargetProcess and thread watching for JOB_OBJECT_MSG_ACTIVE_PROCESS_ZERO. > CHECK seem to have introduced with CL https://codereview.chromium.org/1045513004 > > BUG=480639 > R=cpu@chromium.org,grt@chromium.org > > Committed: https://crrev.com/dfb73a76e24eadbb2311c7b756c0383acefc8f06 > Cr-Commit-Position: refs/heads/master@{#327348} TBR=cpu@chromium.org,rvargas@chromium.org,shrikant@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480639 Committed: https://crrev.com/bd7754c1ce9c6d95d18b44de8ff424417af3890a Cr-Commit-Position: refs/heads/master@{#327643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M base/win/scoped_handle.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
Created Revert of Conv CHECK->DCHECK in CloseHandle (top crasher & data enough to debug)
5 years, 7 months ago (2015-04-30 02:46:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109423003/1
5 years, 7 months ago (2015-04-30 02:47:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 02:47:50 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 02:48:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd7754c1ce9c6d95d18b44de8ff424417af3890a
Cr-Commit-Position: refs/heads/master@{#327643}

Powered by Google App Engine
This is Rietveld 408576698