Browser Plugin: More robust recovery from guest crash

content/renderer/browser_plugin/browser_plugin.cc

Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index adde725e61b83c614b638541935b9a737c56661b..a72fa92bf1cad33edd6b5564d920af66c5a85276 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -137,7 +137,6 @@ void BrowserPlugin::SetSrcAttribute(const std::string& src) {
     navigate_src_sent_ = true;
   }
   src_ = src;
-  guest_crashed_ = false;
 }
 
 std::string BrowserPlugin::GetPartitionAttribute() const {
@@ -266,7 +265,6 @@ void BrowserPlugin::Stop() {
 void BrowserPlugin::Reload() {
   if (!navigate_src_sent_)
     return;
-  guest_crashed_ = false;
   BrowserPluginManager::Get()->Send(
       new BrowserPluginHostMsg_Reload(render_view_->GetRoutingID(),
                                       instance_id_));
@@ -285,6 +283,8 @@ void BrowserPlugin::UpdateRect(
     return;
   }
 
+  // If we're getting new pixels then a guest is available again.
+  guest_crashed_ = false;

[Charlie Reis, 2012/10/12 04:10:25]

Wouldn't DidNavigate/LoadCommit be a better place for this?  If any page
commits, we know we're no longer crashed.  (That seems closer to the invariant I
would expect, as well as how the browser process handles it, rather than
inferring it from graphical updates.)

[Fady Samuel, 2012/10/12 17:33:06]

Done.

   float backing_store_scale_factor =
       backing_store_.get() ? backing_store_->GetScaleFactor() : 1.0f;