Issue 11094061: drive: Move IsDriveEnabled() and DisableDrive() to DriveSystemService

Issue 11094061: drive: Move IsDriveEnabled() and DisableDrive() to DriveSystemService (Closed)

Created:
8 years, 2 months ago by satorux1

Modified:
8 years, 2 months ago

Reviewers:
hashimoto, nhiroki

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@drive_available

Visibility:
Public.

More Reviews

Description

drive: Move IsDriveEnabled() and DisableDrive() to DriveSystemService These functions are part of Drive on Chrome OS, hence should be moved to chromeos/gdata. BUG=153962 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161293

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : address comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -59 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_system_service.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_system_service.cc	View	1 2	4 chunks	+39 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_util.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_util.cc	View		1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

8 years, 2 months ago (2012-10-11 03:33:40 UTC) #3

hashimoto

https://chromiumcodereview.appspot.com/11094061/diff/2005/chrome/browser/chromeos/gdata/drive_system_service.h File chrome/browser/chromeos/gdata/drive_system_service.h (right): https://chromiumcodereview.appspot.com/11094061/diff/2005/chrome/browser/chromeos/gdata/drive_system_service.h#newcode85 chrome/browser/chromeos/gdata/drive_system_service.h:85: static void DisableDrive(Profile* profile); Can't this method be a ...

8 years, 2 months ago (2012-10-11 04:09:15 UTC) #5

satorux1

http://codereview.chromium.org/11094061/diff/2005/chrome/browser/chromeos/gdata/drive_system_service.h File chrome/browser/chromeos/gdata/drive_system_service.h (right): http://codereview.chromium.org/11094061/diff/2005/chrome/browser/chromeos/gdata/drive_system_service.h#newcode85 chrome/browser/chromeos/gdata/drive_system_service.h:85: static void DisableDrive(Profile* profile); On 2012/10/11 04:09:15, hashimoto wrote: ...

8 years, 2 months ago (2012-10-11 04:25:31 UTC) #6

lgtm

Expand Messages | Collapse Messages