chrome/test/base/in_process_browser_test.cc - Issue 11094040: BrowserTestBase::CreateTestServer should accept FilePath

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 11094040: BrowserTestBase::CreateTestServer should accept FilePath (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/in_process_browser_test.cc

diff --git a/chrome/test/base/in_process_browser_test.cc b/chrome/test/base/in_process_browser_test.cc

index 94c6fc86d6998811ebeb0171bd1e955a0c7e0f7f..44100ea1335fafc4ce6114651a2af4741665b00b 100644

--- a/chrome/test/base/in_process_browser_test.cc

+++ b/chrome/test/base/in_process_browser_test.cc

@@ -79,7 +79,9 @@ InProcessBrowserTest::InProcessBrowserTest()

chrome_path = chrome_path.Append(chrome::kBrowserProcessExecutablePath);

CHECK(PathService::Override(base::FILE_EXE, chrome_path));

#endif // defined(OS_MACOSX)

- CreateTestServer("chrome/test/data");

+ CreateTestServer(FilePath(FILE_PATH_LITERAL("chrome"))

+ .Append(FILE_PATH_LITERAL("test"))

+ .Append(FILE_PATH_LITERAL("data")));

Ryan Sleevi 2012/10/10 17:38:40 FILE_PATH_LITERAL("chrome/test/data") ?

Takashi Toyoshima 2012/10/11 03:55:37 Done.

}

InProcessBrowserTest::~InProcessBrowserTest() {