pkg/compiler/lib/src/js_backend/codegen/task.dart - Issue 1109403002: cps-ir: Support compilation of methods that use interceptor calling convention.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/task.dart

Issue 1109403002: cps-ir: Support compilation of methods that use interceptor calling convention. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/glue.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/type_test_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/codegen/task.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/task.dart b/pkg/compiler/lib/src/js_backend/codegen/task.dart

index 89cf74c200ca98c655a7461c10752d06096165c7..3befc854bed4ab103be8ebf18f82d2c6628b5e93 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/task.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/task.dart

@@ -117,13 +117,6 @@ class CpsFunctionCompiler implements FunctionCompiler {

giveUp(irBuilderTask.bailoutMessage);

}

- if (element.isInstanceMember && !element.isGenerativeConstructorBody) {

- Selector selector = new Selector.fromElement(cpsNode.element);

- if (glue.isInterceptedSelector(selector)) {

- giveUp('cannot compile methods that need interceptor calling '

- 'convention.');

- }

traceGraph("IR Builder", cpsNode);

new UnsugarVisitor(glue).rewrite(cpsNode);

traceGraph("Unsugaring", cpsNode);