cps-ir: Support compilation of methods that use interceptor calling convention.

cps-ir: Support compilation of methods that use interceptor calling convention.

This is a modified version of sra@'s CL https://codereview.chromium.org/1020243002/ with kmillikin@'s comments addressed.

R=sigurdm@google.com, kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45680

[sigurdm, 2015-04-30 08:57:43]

sigurdm@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2015-04-30 08:57:44]

LGTM

https://codereview.chromium.org/1109403002/diff/30001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/codegen/unsugar.dart (right):

https://codereview.chromium.org/1109403002/diff/30001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:108: void
insertEqNullCheck(FunctionDefinition function) {
Is this rewrite correct in the presence of mirrors:

import "dart:mirrors";

class A {
  operator == (other) {
    throw "BAD";
  }
}

void main() {
  A a = new A();
  print(a == null);

  var am = reflect(a);
  print(am.invoke(const Symbol("=="), [null]));
}

Should this program throw on the mirror invocation? That is how I read the spec
16.22. But it seems that is not how it is implemented currently - also not in
the vm.

https://codereview.chromium.org/1109403002/diff/30001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:217: // If the receiver is
the explicit receiver, we are calling a method in the
Long line

[karlklose, 2015-05-11 12:38:43]

Committed patchset #4 (id:40001) manually as 45680 (presubmit successful).