chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc - Issue 1109393011: Pull back windows to the original user desktop when clicking on the correspond window list bubble i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

Issue 1109393011: Pull back windows to the original user desktop when clicking on the correspond window list bubble i… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address pkasting@'s comment. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc ('k') | chrome/browser/ui/views/frame/system_menu_model_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

index b1ce6d6d3ca34b2ca2e68cbeb8a3693ee46ed11f..0c263b8f0e0c9a31321f1b853218bf5ac0bdd5ff 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h"

#include "ash/wm/window_util.h"

+#include "chrome/browser/ui/ash/multi_user/multi_user_util.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_window.h"

@@ -43,6 +44,10 @@ void ChromeLauncherAppMenuItemTab::Execute(int event_flags) {

if (event_flags & (ui::EF_SHIFT_DOWN | ui::EF_MIDDLE_MOUSE_BUTTON)) {

tab_strip->CloseWebContentsAt(index, TabStripModel::CLOSE_USER_GESTURE);

} else {

+ // In ChromeOS multiprofile scenario we might need to teleport the window

+ // back to the current user desktop.

+ multi_user_util::MoveWindowToCurrentDesktop(

+ browser->window()->GetNativeWindow());

tab_strip->ActivateTabAt(index, false);

browser->window()->Show();

// Need this check to prevent unit tests from crashing.