Pull back windows to the original user desktop when clicking on the correspond window list bubble i…

chrome/browser/ui/views/frame/system_menu_model_builder.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/system_menu_model_builder.h"
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/toolbar/wrench_menu_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/base/models/simple_menu_model.h"
 
 #if defined(OS_CHROMEOS)
 #include "ash/session/session_state_delegate.h"
 #include "ash/shell.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_window_manager.h"
 #include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/url_constants.h"
 #include "components/user_manager/user_info.h"
 #include "ui/base/l10n/l10n_util.h"
 #endif
 
+namespace {
+
+// Check if the current browser window contains chrome://settings page or
+// subpages.

[Mr4D (OOO till 08-26), 2015/05/03 19:53:45]

If not mistaken, we stated in the issue that we only want to suppress the
settings APP - NOT browser individual pages.

As such - you should see if the window is an application and if it is the
settings app - not if one of the tabs contains a settings app.

[xdai1, 2015/05/04 16:54:56]

This function is only called by
SystemMenuModelBuilder::BuildSystemMenuForAppOrPopupWindow(), which means it is
a dedicated setting window or application. 

[Mr4D (OOO till 08-26), 2015/05/04 17:07:41]

Right - but it has an impact on tabbed browser windows. 

Imagine you (user) can teleport one tabbed browser window but not another. How
should the user know why that is? Isn't that confusing?

Looking at the issue, we agreed that we would only block *settings applications*
from getting teleported. Tabbed browser windows however would be able to get
teleported.

Your code hinders tabbed browser windows to get teleported - which is not
correct. 

+bool IsChromeSettingsWindow(Browser* browser) {
+  const base::string16 kChromeSetting =
+      base::ASCIIToUTF16(content::kChromeUIScheme) +
+      base::ASCIIToUTF16(url::kStandardSchemeSeparator) +
+      base::ASCIIToUTF16(chrome::kChromeUISettingsHost);
+
+  if (browser) {
+    TabStripModel* tab_strip = browser->tab_strip_model();
+    for (int i = 0; i < tab_strip->count(); i++) {
+      const base::string16 gurl_spec = base::UTF8ToUTF16(
+          browser->tab_strip_model()->GetWebContentsAt(i)->GetURL().spec());
+      if (gurl_spec.find(kChromeSetting) != base::string16::npos)
+        return true;
+    }
+  }
+  return false;
+}
+
+}  // namespace
+
 SystemMenuModelBuilder::SystemMenuModelBuilder(
     ui::AcceleratorProvider* provider,
     Browser* browser)
     : menu_delegate_(provider, browser) {
 }
 
 SystemMenuModelBuilder::~SystemMenuModelBuilder() {
 }
 
 void SystemMenuModelBuilder::Init() {
@@ skipping 63 matching lines @@
                                 encoding_menu_contents_.get());
   if (browser()->is_app() && chrome::CanOpenTaskManager()) {
     model->AddSeparator(ui::NORMAL_SEPARATOR);
     model->AddItemWithStringId(IDC_TASK_MANAGER, IDS_TASK_MANAGER);
   }
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   model->AddSeparator(ui::NORMAL_SEPARATOR);
   model->AddItemWithStringId(IDC_CLOSE_WINDOW, IDS_CLOSE);
 #endif
 
-  AppendTeleportMenu(model);
+  // We don't append teleport menu for Chrome Settings window.
+  if (!IsChromeSettingsWindow(browser()))
+    AppendTeleportMenu(model);
 }
 
 void SystemMenuModelBuilder::AddFrameToggleItems(ui::SimpleMenuModel* model) {
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDebugEnableFrameToggle)) {
     model->AddSeparator(ui::NORMAL_SEPARATOR);
     model->AddItem(IDC_DEBUG_FRAME_TOGGLE,
                    base::ASCIIToUTF16("Toggle Frame Type"));
   }
 }
@@ skipping 33 matching lines @@
     const user_manager::UserInfo* user_info = delegate->GetUserInfo(user_index);
     model->AddItem(
         user_index == 1 ? IDC_VISIT_DESKTOP_OF_LRU_USER_2
                         : IDC_VISIT_DESKTOP_OF_LRU_USER_3,
         l10n_util::GetStringFUTF16(IDS_VISIT_DESKTOP_OF_LRU_USER,
                                    user_info->GetDisplayName(),
                                    base::ASCIIToUTF16(user_info->GetEmail())));
   }
 #endif
 }