Pull back windows to the original user desktop when clicking on the correspond window list bubble i…

chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h"
 
 #include "ash/ash_switches.h"
 #include "ash/multi_profile_uma.h"
 #include "ash/root_window_controller.h"
 #include "ash/session/session_state_delegate.h"
 #include "ash/shelf/shelf.h"
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #include "ash/shell_window_ids.h"
 #include "ash/system/tray/system_tray_notifier.h"
 #include "ash/wm/maximize_mode/maximize_mode_controller.h"
 #include "ash/wm/window_state.h"
 #include "base/auto_reset.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/login/session/user_session_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
 #include "chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/url_constants.h"
 #include "content/public/browser/notification_service.h"
 #include "extensions/browser/app_window/app_window.h"
 #include "extensions/browser/app_window/app_window_registry.h"
 #include "google_apis/gaia/gaia_auth_util.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/base/ui_base_types.h"
 #include "ui/events/event.h"
 #include "ui/message_center/message_center.h"
@@ skipping 93 matching lines @@
           extensions::AppWindow::WINDOW_TYPE_V1_PANEL) {
         window_type = ash::MultiProfileUMA::TELEPORT_WINDOW_PANEL;
       } else {
         window_type = ash::MultiProfileUMA::TELEPORT_WINDOW_V2_APP;
       }
     }
   }
   ash::MultiProfileUMA::RecordTeleportWindowType(window_type);
 }
 
+// Check if the current browser window contains chrome://settings page or
+// subpages.
+bool IsWindowContainsChromeSettingsPages(aura::Window* window) {
+  const base::string16 kChromeSetting =
+      base::ASCIIToUTF16(content::kChromeUIScheme) +
+      base::ASCIIToUTF16(url::kStandardSchemeSeparator) +
+      base::ASCIIToUTF16(chrome::kChromeUISettingsHost);
+
+  Browser* browser = chrome::FindBrowserWithWindow(window);
+  if (browser) {
+    TabStripModel* tab_strip = browser->tab_strip_model();
+    for (int i = 0; i < tab_strip->count(); i++) {
+      const base::string16 gurl_spec = base::UTF8ToUTF16(
+          browser->tab_strip_model()->GetWebContentsAt(i)->GetURL().spec());
+      if (gurl_spec.find(kChromeSetting) != base::string16::npos)
+        return true;
+    }
+  }
+  return false;
+}
+
 }  // namespace
 
 namespace chrome {
 
 // A class to temporarily change the animation properties for a window.
 class AnimationSetter {
  public:
   AnimationSetter(aura::Window* window, int animation_time_in_ms)
       : window_(window),
         previous_animation_type_(
@@ skipping 154 matching lines @@
 const std::string& MultiUserWindowManagerChromeOS::GetWindowOwner(
     aura::Window* window) const {
   WindowToEntryMap::const_iterator it = window_to_entry_.find(window);
   return it != window_to_entry_.end() ? it->second->owner()
                                       : base::EmptyString();
 }
 
 void MultiUserWindowManagerChromeOS::ShowWindowForUser(
     aura::Window* window,
     const std::string& user_id) {
+  // If the browser window contains ChromeSettings or ChromeSettingsSubpages
+  // child windows, we should not teleport this window to another user's
+  // desktop.

[Mr4D (OOO till 08-26), 2015/04/30 21:51:45]

Why? This does not make sense. I do not see why we should not be able to move
such a window to another desktop.

Note also: If we would really would do this... 

... we would need to intercept navigation operations in the browser and
automatically pull windows back to the user's desktop which would then be
totally confusing.
... we would need to disallow teleporting of such windows in the first place by
removing the menu entry from the context menu, since otherwise the user would
try to move the window and it would not move.

+  if (IsWindowContainsChromeSettingsPages(window)) {
+    // I'm not sure what to do here. Give user some error information?
+    return;
+  }
+
   std::string previous_owner(GetUserPresentingWindow(window));
   if (!ShowWindowForUserIntern(window, user_id))
     return;
   // The window switched to a new desktop and we have to switch to that desktop,
   // but only when it was on the visible desktop and the the target is not the
   // visible desktop.
   if (user_id == current_user_id_ || previous_owner != current_user_id_)
     return;
 
   ash::Shell::GetInstance()->session_state_delegate()->SwitchActiveUser(
@@ skipping 408 matching lines @@
   DCHECK_EQ(visible, window->IsVisible());
 }
 
 int MultiUserWindowManagerChromeOS::GetAdjustedAnimationTimeInMS(
     int default_time_in_ms) const {
   return animation_speed_ == ANIMATION_SPEED_NORMAL ? default_time_in_ms :
       (animation_speed_ == ANIMATION_SPEED_FAST ? 10 : 0);
 }
 
 }  // namespace chrome