Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1109393005: Revert "Enable BlockingLoginTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest, for webv… (Closed)

Created:
5 years, 7 months ago by Stephen White
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Enable BlockingLoginTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest, for webview." This reverts commit 8c52ec023857ec7d082d54518864edd84d25b116. This seems to be breaking "Linux ChromiumOS Tests (dbg)" on the Blink waterfall, and blocking the Blink roll: http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1485 TBR=achuith,nkostylev@chromium.org BUG= NOTREECHECKS=true Committed: https://crrev.com/a5080f268e879b41a34a3f912fb5dabfc6b7a2dd Cr-Commit-Position: refs/heads/master@{#327552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -99 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +11 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 5 chunks +36 lines, -40 lines 0 comments Download
M chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc View 6 chunks +8 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M chromeos/login/auth/auth_status_consumer.h View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109393005/1
5 years, 7 months ago (2015-04-29 19:11:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109393005/1
5 years, 7 months ago (2015-04-29 20:22:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 20:23:52 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5080f268e879b41a34a3f912fb5dabfc6b7a2dd Cr-Commit-Position: refs/heads/master@{#327552}
5 years, 7 months ago (2015-04-29 20:25:09 UTC) #7
achuithb
On 2015/04/29 20:25:09, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 7 months ago (2015-04-29 22:42:41 UTC) #8
achuithb
5 years, 7 months ago (2015-04-29 22:44:03 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1111593006/ by achuith@chromium.org.

The reason for reverting is: This was a speculative revert, but I don't believe
the browser tests reverted here were the cause of the blink failures..

Powered by Google App Engine
This is Rietveld 408576698