Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1109393002: Pass gfx structs by const ref (gfx::PointF) (Closed)

Created:
5 years, 7 months ago by a.berwal
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass gfx structs by const ref (gfx::PointF) Avoid unneccessary copy of structures gfx::PointF by passing them by const ref rather than value. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters. Reviewed at https://chromiumcodereview.appspot.com/139233002 BUG=159273 Committed: https://crrev.com/0c9d20046ecd599c511fd7f4ff8e8df83230b03d Cr-Commit-Position: refs/heads/master@{#327651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M cc/layers/texture_layer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/velocity_tracker_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
a.berwal
PTAL
5 years, 7 months ago (2015-04-29 12:14:19 UTC) #2
Avi (use Gerrit)
LGTM
5 years, 7 months ago (2015-04-29 15:19:46 UTC) #3
danakj
LGTM
5 years, 7 months ago (2015-04-29 17:01:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109393002/1
5 years, 7 months ago (2015-04-30 03:14:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 04:10:37 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 04:11:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c9d20046ecd599c511fd7f4ff8e8df83230b03d
Cr-Commit-Position: refs/heads/master@{#327651}

Powered by Google App Engine
This is Rietveld 408576698