src/factory.cc - Issue 1109353003: Unify internal and external typed arrays a bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 1109353003: Unify internal and external typed arrays a bit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index ddb6a648e3613019d0a17ace06cb8d398bcfd674..3df71b19c3eff44a4da5f1ea59be9b492df33c4b 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1987,7 +1987,9 @@ Handle<JSTypedArray> Factory::NewJSTypedArray(ElementsKind elements_kind,

Handle<Object> length_object = NewNumberFromSize(number_of_elements);

obj->set_length(*length_object);

- obj->set_buffer(Smi::FromInt(0));

+ Handle<JSArrayBuffer> buffer = isolate()->factory()->NewJSArrayBuffer();

+ Runtime::SetupArrayBuffer(isolate(), buffer, true, NULL, byte_length);

+ obj->set_buffer(*buffer);

Handle<FixedTypedArrayBase> elements =

isolate()->factory()->NewFixedTypedArray(

static_cast<int>(number_of_elements), array_type);

« no previous file with comments | « src/contexts.h ('k') | src/hydrogen.h » ('j') | no next file with comments »