Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1109353002: Use of base::StringPairs appropriately in cache_storage (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in cache_storage Bescause base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/dcb16e1031515df0e6f17d6451e5ae9a1070a8cd Cr-Commit-Position: refs/heads/master@{#327506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-04-29 10:12:30 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-04-29 15:18:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109353002/1
5 years, 7 months ago (2015-04-29 16:21:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 16:44:52 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 16:45:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcb16e1031515df0e6f17d6451e5ae9a1070a8cd
Cr-Commit-Position: refs/heads/master@{#327506}

Powered by Google App Engine
This is Rietveld 408576698