Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1109343004: Wrap v8natives.js into a function. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wrap v8natives.js into a function. R=jkummerow@chromium.org Committed: https://crrev.com/ee1b39b4303829e6c6805fe8b2f2602b13f6463a Cr-Commit-Position: refs/heads/master@{#28174}

Patch Set 1 #

Total comments: 2

Patch Set 2 : alpha sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -398 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/array.js View 9 chunks +10 lines, -10 lines 0 comments Download
M src/array-iterator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/collection.js View 6 chunks +8 lines, -8 lines 0 comments Download
M src/collection-iterator.js View 2 chunks +6 lines, -6 lines 0 comments Download
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/generator.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-array.js View 5 chunks +6 lines, -6 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 3 chunks +9 lines, -4 lines 0 comments Download
M src/i18n.js View 28 chunks +60 lines, -61 lines 0 comments Download
M src/isolate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/isolate.cc View 3 chunks +27 lines, -26 lines 0 comments Download
M src/json.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 12 chunks +23 lines, -15 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/object-observe.js View 6 chunks +9 lines, -9 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/string.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/string-iterator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/symbol.js View 4 chunks +5 lines, -5 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 7 chunks +37 lines, -31 lines 0 comments Download
M src/uri.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 1 14 chunks +204 lines, -175 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/jsnatives.js View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/jsmin.py View 7 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 7 months ago (2015-04-30 08:29:25 UTC) #1
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1109343004/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/1109343004/diff/1/src/v8natives.js#newcode7 src/v8natives.js:7: var $setFunctionName; nit: I think this ...
5 years, 7 months ago (2015-04-30 13:40:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109343004/20001
5 years, 7 months ago (2015-04-30 13:46:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 14:59:07 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ee1b39b4303829e6c6805fe8b2f2602b13f6463a Cr-Commit-Position: refs/heads/master@{#28174}
5 years, 7 months ago (2015-04-30 14:59:26 UTC) #7
Michael Achenbach
5 years, 7 months ago (2015-04-30 17:31:23 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1121453003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for breaking layout
tests, e.g.:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg...

See. e.g.:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/313....

Powered by Google App Engine
This is Rietveld 408576698