Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1109333003: Use a stub in crankshaft for grow store arrays. (Closed)

Created:
5 years, 7 months ago by mvstanton
Modified:
5 years, 7 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use a stub in crankshaft for grow store arrays. We were deopting without learning anything. This is a rebase/reland of https://codereview.chromium.org/368263003 BUG=v8:3417 LOG=N Committed: https://crrev.com/fb8e6136387339e8089bbf61d4ffee50e4cd957e Cr-Commit-Position: refs/heads/master@{#28163}

Patch Set 1 #

Patch Set 2 : Ports and test. #

Patch Set 3 : Fix ARM failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -28 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +34 lines, -10 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +13 lines, -1 line 0 comments Download
M src/interface-descriptors.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +10 lines, -5 lines 0 comments Download
M src/objects.cc View 5 chunks +24 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/ensure-growing-store-learns.js View 1 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mvstanton
Hi Danno, Here is a rebase of what you reviewed before. It's exactly the same ...
5 years, 7 months ago (2015-04-30 08:18:45 UTC) #2
mvstanton
Hi Danno, Slight change o' strategy. I'd like to land this CL. The extra work ...
5 years, 7 months ago (2015-04-30 09:40:25 UTC) #3
danno
lgtm
5 years, 7 months ago (2015-04-30 12:26:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109333003/40001
5 years, 7 months ago (2015-04-30 12:26:45 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-30 12:34:08 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 12:34:26 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fb8e6136387339e8089bbf61d4ffee50e4cd957e
Cr-Commit-Position: refs/heads/master@{#28163}

Powered by Google App Engine
This is Rietveld 408576698