<webview>: First stab at implementing media permission request for guests.

content/renderer/browser_plugin/browser_plugin_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin_bindings.h"
 
 #include <cstdlib>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 26 matching lines @@
 namespace {
 
 // Method bindings.
 const char kMethodBack[] = "back";
 const char kMethodCanGoBack[] = "canGoBack";
 const char kMethodCanGoForward[] = "canGoForward";
 const char kMethodForward[] = "forward";
 const char kMethodGetProcessId[] = "getProcessId";
 const char kMethodGo[] = "go";
 const char kMethodReload[] = "reload";
+const char kMethodSetMediaPermission[] = "setMediaPermission";

[Charlie Reis, 2012/12/07 19:16:25]

What is this for?  I don't remember it in the API discussions.

If this is just an implementation detail, can it be hidden from actual pages? 
Seems like it would allow bypassing the listeners.

[lazyboy, 2012/12/07 22:50:44]

This is just an impl details, right. It is only exposed in the <object>, not the
<webview> tag.

I'm tyring to think what kind of (unexpected) bypassing might happen even if
this somehow gets exposed... Do you have a case where this can trigger
unexpected allow/deny?

[Charlie Reis, 2012/12/17 22:28:09]

It certainly looks like the embedder could call
someObjectTag.setMediaPermission(42, true) to bypass the existing event
listeners, if it could guess the request_id (e.g., 42).  That would defeat app
developers who try to install security policies to restrict their own app's
behavior, which isn't ok.

[Fady Samuel, 2013/02/05 17:53:26]

This is not forwarded from the shim to the BrowserPlugin.

 const char kMethodStop[] = "stop";
 const char kMethodTerminate[] = "terminate";
 
 // Attributes.
 const char kAttributeAutoSize[] = "autoSize";
 const char kAttributeContentWindow[] = "contentWindow";
 const char kAttributeMaxHeight[] = "maxHeight";
 const char kAttributeMaxWidth[] = "maxWidth";
 const char kAttributeMinHeight[] = "minHeight";
 const char kAttributeMinWidth[] = "minWidth";
@@ skipping 305 matching lines @@
                       const NPVariant* args,
                       NPVariant* result) OVERRIDE {
     bindings->instance()->Stop();
     return true;
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingStop);
 };
 
+class BrowserPluginBindingSetMediaPermission
+    : public BrowserPluginMethodBinding {
+ public:
+  BrowserPluginBindingSetMediaPermission()
+      : BrowserPluginMethodBinding(kMethodSetMediaPermission, 2) {
+  }
+
+  virtual bool Invoke(BrowserPluginBindings* bindings,
+                      const NPVariant* args,
+                      NPVariant* result) OVERRIDE {
+    int request_id = Int32FromNPVariant(args[0]);
+    bool allow = NPVARIANT_TO_BOOLEAN(args[1]);
+    bindings->instance()->RespondMediaAccess(request_id, allow);
+    return true;
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingSetMediaPermission);
+};
+
 class BrowserPluginBindingTerminate : public BrowserPluginMethodBinding {
  public:
   BrowserPluginBindingTerminate()
       : BrowserPluginMethodBinding(kMethodTerminate, 0) {
   }
 
   virtual bool Invoke(BrowserPluginBindings* bindings,
                       const NPVariant* args,
                       NPVariant* result) OVERRIDE {
     bindings->instance()->TerminateGuest();
@@ skipping 274 matching lines @@
   np_object_ = static_cast<BrowserPluginBindings::BrowserPluginNPObject*>(obj);
   np_object_->message_channel = weak_ptr_factory_.GetWeakPtr();
 
   method_bindings_.push_back(new BrowserPluginBindingBack);
   method_bindings_.push_back(new BrowserPluginBindingCanGoBack);
   method_bindings_.push_back(new BrowserPluginBindingCanGoForward);
   method_bindings_.push_back(new BrowserPluginBindingForward);
   method_bindings_.push_back(new BrowserPluginBindingGetProcessID);
   method_bindings_.push_back(new BrowserPluginBindingGo);
   method_bindings_.push_back(new BrowserPluginBindingReload);
+  method_bindings_.push_back(new BrowserPluginBindingSetMediaPermission);
   method_bindings_.push_back(new BrowserPluginBindingStop);
   method_bindings_.push_back(new BrowserPluginBindingTerminate);
 
   property_bindings_.push_back(new BrowserPluginPropertyBindingAutoSize);
   property_bindings_.push_back(new BrowserPluginPropertyBindingContentWindow);
   property_bindings_.push_back(new BrowserPluginPropertyBindingMaxHeight);
   property_bindings_.push_back(new BrowserPluginPropertyBindingMaxWidth);
   property_bindings_.push_back(new BrowserPluginPropertyBindingMinHeight);
   property_bindings_.push_back(new BrowserPluginPropertyBindingMinWidth);
   property_bindings_.push_back(new BrowserPluginPropertyBindingPartition);
@@ skipping 58 matching lines @@
   for (PropertyBindingList::iterator iter = property_bindings_.begin();
        iter != property_bindings_.end();
        ++iter) {
     if ((*iter)->MatchesName(name))
       return (*iter)->GetProperty(this, result);
   }
   return false;
 }
 
 }  // namespace content