<webview>: First stab at implementing media permission request for guests.

content/renderer/browser_plugin/browser_plugin_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin_bindings.h"
 
 #include <cstdlib>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 320 matching lines @@
                       const NPVariant* args,
                       NPVariant* result) OVERRIDE {
     bindings->instance()->Go(Int32FromNPVariant(args[0]));
     return true;
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingGo);
 };
 
+// Note: This is a method that is used internally by the <webview> shim only.
+// This should not be exposed to developers.
+class BrowserPluginBindingPersistRequestObject

[Fady Samuel, 2013/02/07 15:40:34]

Get rid of "request" to allow this to be used by window.open.

[lazyboy, 2013/02/07 21:24:41]

See my comments in .cc file.

+    : public BrowserPluginMethodBinding {
+ public:
+  BrowserPluginBindingPersistRequestObject()
+      : BrowserPluginMethodBinding(browser_plugin::kMethodInternalPersistObject,
+                                   2) {
+  }
+
+  virtual bool Invoke(BrowserPluginBindings* bindings,
+                      const NPVariant* args,
+                      NPVariant* result) OVERRIDE {
+    bindings->instance()->PersistRequestObject(
+        &args[0], Int32FromNPVariant(args[1]));
+    return true;
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingPersistRequestObject);
+};
+
 class BrowserPluginBindingReload : public BrowserPluginMethodBinding {
  public:
   BrowserPluginBindingReload()
       : BrowserPluginMethodBinding(browser_plugin::kMethodReload, 0) {
   }
 
   virtual bool Invoke(BrowserPluginBindings* bindings,
                       const NPVariant* args,
                       NPVariant* result) OVERRIDE {
     bindings->instance()->Reload();
@@ skipping 14 matching lines @@
                       const NPVariant* args,
                       NPVariant* result) OVERRIDE {
     bindings->instance()->Stop();
     return true;
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingStop);
 };
 
+// Note: This is a method that is used internally by the <webview> shim only.
+// This should not be exposed to developers.
+class BrowserPluginBindingSetMediaPermission
+    : public BrowserPluginMethodBinding {
+ public:
+  BrowserPluginBindingSetMediaPermission()

[Fady Samuel, 2013/02/07 15:40:34]

To reduce the number of new methods we introduce, how about a more general
SetPermissionResponse(request_id, allow).

[lazyboy, 2013/02/07 21:24:41]

Done.

+      : BrowserPluginMethodBinding(
+          browser_plugin::kMethodInternalSetMediaPermission, 2) {
+  }
+
+  virtual bool Invoke(BrowserPluginBindings* bindings,
+                      const NPVariant* args,
+                      NPVariant* result) OVERRIDE {
+    int request_id = Int32FromNPVariant(args[0]);
+    bool allow = NPVARIANT_TO_BOOLEAN(args[1]);
+    bindings->instance()->OnListenerCallMediaAccess(request_id, allow);
+    return true;
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingSetMediaPermission);
+};
+
 class BrowserPluginBindingTerminate : public BrowserPluginMethodBinding {
  public:
   BrowserPluginBindingTerminate()
       : BrowserPluginMethodBinding(browser_plugin::kMethodTerminate, 0) {
   }
 
   virtual bool Invoke(BrowserPluginBindings* bindings,
                       const NPVariant* args,
                       NPVariant* result) OVERRIDE {
     bindings->instance()->TerminateGuest();
@@ skipping 363 matching lines @@
   np_object_ = static_cast<BrowserPluginBindings::BrowserPluginNPObject*>(obj);
   np_object_->message_channel = weak_ptr_factory_.GetWeakPtr();
 
   method_bindings_.push_back(new BrowserPluginBindingBack);
   method_bindings_.push_back(new BrowserPluginBindingCanGoBack);
   method_bindings_.push_back(new BrowserPluginBindingCanGoForward);
   method_bindings_.push_back(new BrowserPluginBindingForward);
   method_bindings_.push_back(new BrowserPluginBindingGetProcessID);
   method_bindings_.push_back(new BrowserPluginBindingGetRouteID);
   method_bindings_.push_back(new BrowserPluginBindingGo);
+  method_bindings_.push_back(new BrowserPluginBindingPersistRequestObject);
   method_bindings_.push_back(new BrowserPluginBindingReload);
+  method_bindings_.push_back(new BrowserPluginBindingSetMediaPermission);
   method_bindings_.push_back(new BrowserPluginBindingStop);
   method_bindings_.push_back(new BrowserPluginBindingTerminate);
 
   property_bindings_.push_back(new BrowserPluginPropertyBindingAutoSize);
   property_bindings_.push_back(new BrowserPluginPropertyBindingContentWindow);
   property_bindings_.push_back(new BrowserPluginPropertyBindingMaxHeight);
   property_bindings_.push_back(new BrowserPluginPropertyBindingMaxWidth);
   property_bindings_.push_back(new BrowserPluginPropertyBindingMinHeight);
   property_bindings_.push_back(new BrowserPluginPropertyBindingMinWidth);
   property_bindings_.push_back(new BrowserPluginPropertyBindingName);
@@ skipping 71 matching lines @@
   for (PropertyBindingList::iterator iter = property_bindings_.begin();
        iter != property_bindings_.end();
        ++iter) {
     if ((*iter)->MatchesName(name))
       return (*iter)->GetProperty(this, result);
   }
   return false;
 }
 
 }  // namespace content