Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.cc

Issue 11093074: Get rid of static module allocation, do it in code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed last comments; added other back-ends Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1111 accumulator->Put(str); 1111 accumulator->Put(str);
1112 accumulator->Put('>'); 1112 accumulator->Put('>');
1113 printed = true; 1113 printed = true;
1114 } 1114 }
1115 } 1115 }
1116 if (!printed) { 1116 if (!printed) {
1117 accumulator->Add("<JS Function>"); 1117 accumulator->Add("<JS Function>");
1118 } 1118 }
1119 break; 1119 break;
1120 } 1120 }
1121 case JS_MODULE_TYPE: {
1122 accumulator->Add("<JS Module>");
1123 break;
1124 }
1121 // All other JSObjects are rather similar to each other (JSObject, 1125 // All other JSObjects are rather similar to each other (JSObject,
1122 // JSGlobalProxy, JSGlobalObject, JSUndetectableObject, JSValue). 1126 // JSGlobalProxy, JSGlobalObject, JSUndetectableObject, JSValue).
1123 default: { 1127 default: {
1124 Map* map_of_this = map(); 1128 Map* map_of_this = map();
1125 Heap* heap = GetHeap(); 1129 Heap* heap = GetHeap();
1126 Object* constructor = map_of_this->constructor(); 1130 Object* constructor = map_of_this->constructor();
1127 bool printed = false; 1131 bool printed = false;
1128 if (constructor->IsHeapObject() && 1132 if (constructor->IsHeapObject() &&
1129 !heap->Contains(HeapObject::cast(constructor))) { 1133 !heap->Contains(HeapObject::cast(constructor))) {
1130 accumulator->Add("!!!INVALID CONSTRUCTOR!!!"); 1134 accumulator->Add("!!!INVALID CONSTRUCTOR!!!");
(...skipping 12377 matching lines...) Expand 10 before | Expand all | Expand 10 after
13508 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 13512 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
13509 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 13513 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
13510 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 13514 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
13511 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 13515 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
13512 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 13516 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
13513 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 13517 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
13514 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 13518 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
13515 } 13519 }
13516 13520
13517 } } // namespace v8::internal 13521 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698