Issue 11093068: [content shell] Add layout test specific font setup (for linux only right now)

Issue 11093068: [content shell] Add layout test specific font setup (for linux only right now) (Closed)

Created:
8 years, 2 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 2 months ago

Reviewers:
jam, marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[content shell] Add layout test specific font setup (for linux only right now) BUG=111316 TEST=css1/basic/comments.html passes TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161351

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : add DRT dependency #

Patch Set 4 : update #

Patch Set 5 : updates #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -18 lines)			Patch
M	content/content_shell.gypi	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/shell/shell_main_delegate.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
A	content/shell/webkit_test_platform_support.h	View	1 2 3	1 chunk	+10 lines, -0 lines	1 comment	Download
A +	content/shell/webkit_test_platform_support_android.cc	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download
A	content/shell/webkit_test_platform_support_linux.cc	View		1 chunk	+140 lines, -0 lines	0 comments	Download
A +	content/shell/webkit_test_platform_support_mac.mm	View		1 chunk	+3 lines, -6 lines	0 comments	Download
A +	content/shell/webkit_test_platform_support_win.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

plz review Compare: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellX11.cpp I put the call to WebKitPlatformInitialize() when the basic startup is ...

8 years, 2 months ago (2012-10-11 08:42:53 UTC) #1

marja

lgtm http://codereview.chromium.org/11093068/diff/3002/content/shell/webkit_test_platform_support.h File content/shell/webkit_test_platform_support.h (right): http://codereview.chromium.org/11093068/diff/3002/content/shell/webkit_test_platform_support.h#newcode5 content/shell/webkit_test_platform_support.h:5: #ifndef CONTENT_SHELL_WEBKIT_TEST_PLATFORM_SUPPOR_H_ s/SUPPOR/SUPPORT/g

8 years, 2 months ago (2012-10-11 11:49:18 UTC) #2

jochen (gone - plz use gerrit)

John, I've added files to content shell, and a missing dependency to content_browsertests, tbr'ing this ...

8 years, 2 months ago (2012-10-11 14:54:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11093068/7003

8 years, 2 months ago (2012-10-11 14:55:00 UTC) #4

jam

8 years, 2 months ago (2012-10-11 15:21:53 UTC) #5

lgtm

https://codereview.chromium.org/11093068/diff/7003/content/shell/webkit_test_...
File content/shell/webkit_test_platform_support.h (right):

https://codereview.chromium.org/11093068/diff/7003/content/shell/webkit_test_...
content/shell/webkit_test_platform_support.h:8: bool
WebKitTestPlatformInitialize();
nit: put this in the content namespace

Expand Messages | Collapse Messages