Enable peerconnection to use the NSS RNG.

content/renderer/media/media_stream_dependency_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_dependency_factory.h"
 
 #include <vector>
 
 #include "base/synchronization/waitable_event.h"
 #include "base/utf_string_conversions.h"
 #include "content/renderer/media/media_stream_source_extra_data.h"
 #include "content/renderer/media/peer_connection_handler_jsep.h"
 #include "content/renderer/media/rtc_peer_connection_handler.h"
 #include "content/renderer/media/rtc_video_capturer.h"
 #include "content/renderer/media/video_capture_impl_manager.h"
 #include "content/renderer/media/webrtc_audio_device_impl.h"
 #include "content/renderer/media/webrtc_uma_histograms.h"
 #include "content/renderer/p2p/ipc_network_manager.h"
 #include "content/renderer/p2p/ipc_socket_factory.h"
 #include "content/renderer/p2p/port_allocator.h"
 #include "jingle/glue/thread_wrapper.h"
+#include "net/socket/nss_ssl_util.h"

[Ryan Sleevi, 2012/10/10 23:59:15]

#if !defined(USE_OPENSSL)
#include "net/socket/nss_ssl_util.h"
#endif

(moved to line 27)

Not sure if Android is using this code yet, but Android won't have this function

[Ronghua Wu (Left Chromium), 2012/10/11 00:17:18]

Done.

 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebMediaStreamComponent.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebMediaStreamDescriptor.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebMediaStreamSource.h"
 
 class P2PPortAllocatorFactory : public webrtc::PortAllocatorFactoryInterface {
  public:
   P2PPortAllocatorFactory(
       content::P2PSocketDispatcher* socket_dispatcher,
       talk_base::NetworkManager* network_manager,
@@ skipping 313 matching lines @@
         base::Unretained(this),
         &event));
     event.Wait();
   }
 
   if (!socket_factory_.get()) {
     socket_factory_.reset(
         new content::IpcPacketSocketFactory(p2p_socket_dispatcher_));
   }
 
+  // Init NSS which will be needed by PeerConnection.

[ekr, 2012/10/10 23:48:34]

I may have lost the thread but I thought we needed ForceNoNSSDbInit() here.

[Ronghua Wu (Left Chromium), 2012/10/11 00:17:18]

Last reply from Ryan seems to say the ForceNSSNoDBInit is not needed. Maybe I
took it wrong.

[Ryan Sleevi, 2012/10/11 00:26:06]

No, you are correct, it is not needed.

If/when it is, the ChromeRenderProcessObserver should be doing it, as part of
the sandbox prep.

+  net::EnsureNSSSSLInit();

[Sergey Ulanov, 2012/10/10 23:59:01]

NSS is initialized in
ChromeRenderProcessObserver::ChromeRenderProcessObserver(). maybe it's better to
change that function to call net::EnsureNSSSSLInit() instead of
crypto::EnsureNSSInit()

[Ryan Sleevi, 2012/10/10 23:59:15]

#if !defined(USE_OPENSSL)
// Init NSS which will be needed by PeerConnection
net::EnsureNSSSSLInit();
#endif

[Ronghua Wu (Left Chromium), 2012/10/11 00:17:18]

Done.

+
   if (!CreatePeerConnectionFactory()) {
     LOG(ERROR) << "Could not create PeerConnection factory";
     return false;
   }
+

[ekr, 2012/10/10 23:48:34]

Whitespace only change.

[Ronghua Wu (Left Chromium), 2012/10/11 00:17:18]

Done.

   return true;
 }
 
 void MediaStreamDependencyFactory::CleanupPeerConnectionFactory() {
   pc_factory_ = NULL;
   if (network_manager_) {
     // The network manager needs to free its resources on the thread they were
     // created, which is the worked thread.
     if (chrome_worker_thread_.IsRunning()) {
       chrome_worker_thread_.message_loop()->PostTask(FROM_HERE, base::Bind(
           &MediaStreamDependencyFactory::DeleteIpcNetworkManager,
           base::Unretained(this)));
       // Stopping the thread will wait until all tasks have been
       // processed before returning. We wait for the above task to finish before
       // letting the the function continue to avoid any potential race issues.
       chrome_worker_thread_.Stop();
     } else {
       NOTREACHED() << "Worker thread not running.";
     }
   }
 }