Issue 11093046: Enable compilation of GDBJIT interface on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11093046: Enable compilation of GDBJIT interface on Linux. (Closed)

Created:
8 years, 2 months ago by Michael Starzinger

Modified:
8 years, 2 months ago

Reviewers:
caseq1, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Enable compilation of GDBJIT interface on Linux. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12685

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. I'd be even happier if there was a way to force-disable GDBJIT even in ...

8 years, 2 months ago (2012-10-10 10:58:24 UTC) #2

caseq1

https://codereview.chromium.org/11093046/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11093046/diff/1/build/common.gypi#newcode354 build/common.gypi:354: 'defines': ['ENABLE_GDB_JIT_INTERFACE',], This broke debugging of chrome, at least ...

8 years, 2 months ago (2012-10-15 17:55:19 UTC) #3

Michael Starzinger

8 years, 2 months ago (2012-10-16 08:19:13 UTC) #4

https://codereview.chromium.org/11093046/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11093046/diff/1/build/common.gypi#newcode354
build/common.gypi:354: 'defines': ['ENABLE_GDB_JIT_INTERFACE',],
I'll fix that and make sure that the GDBJIT support can be turned off with a GYP
flag as you suggested.

Expand Messages | Collapse Messages