Issue 1109253003: Re-land: base: Replace PurgeAndTruncate with Shrink function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1109253003: Re-land: base: Replace PurgeAndTruncate with Shrink function. (Closed)

Created:
5 years, 7 months ago by reveman

Modified:
5 years, 7 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, gavinp+memory_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

Re-land: base: Replace PurgeAndTruncate with Shrink function. This cleans up the API a bit and allows the code to be unit tested. This also prevents ftruncate from being used on Android where shared memory is backed by Ashmem. Ashmem doesn't support ftruncate. BUG=466509 TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest.Shrink Review URL: https://codereview.chromium.org/1018743003 Cr-Commit-Position: refs/heads/master@{#323941} (cherry picked from commit 59d32f501694975c4011ea85a67060a41140d0f4) Committed: https://chromium.googlesource.com/chromium/src/+/26a3fd37afe22223aebcb61b65b189ad90121bc3

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -28 lines)			Patch
M	base/memory/discardable_shared_memory.h	View	3 chunks	+12 lines, -6 lines	0 comments	Download
M	base/memory/discardable_shared_memory.cc	View	2 chunks	+20 lines, -16 lines	0 comments	Download
M	base/memory/discardable_shared_memory_unittest.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	content/common/host_discardable_shared_memory_manager.cc	View	1 chunk	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

reveman

5 years, 7 months ago (2015-04-29 17:09:15 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
26a3fd37afe22223aebcb61b65b189ad90121bc3.

Expand Messages | Collapse Messages