Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 1109223004: [strong] Disallow implicit conversions for add (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback 3 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index 5a3c0e08ac8883fdabe4a9d0a61ef43cb1dcd119..64736a293a912ac50dd4fa24b9a9f5dd99351e11 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -1187,14 +1187,15 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
state.op(), left, right,
Type::String(zone()), right_type,
result_type, state.fixed_right_arg(),
- allocation_mode));
+ allocation_mode, state.language_mode()));
}
if_leftisstring.Else();
{
Push(BuildBinaryOperation(
state.op(), left, right,
left_type, right_type, result_type,
- state.fixed_right_arg(), allocation_mode));
+ state.fixed_right_arg(), allocation_mode,
+ state.language_mode()));
}
if_leftisstring.End();
result = Pop();
@@ -1207,14 +1208,15 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
state.op(), left, right,
left_type, Type::String(zone()),
result_type, state.fixed_right_arg(),
- allocation_mode));
+ allocation_mode, state.language_mode()));
}
if_rightisstring.Else();
{
Push(BuildBinaryOperation(
state.op(), left, right,
left_type, right_type, result_type,
- state.fixed_right_arg(), allocation_mode));
+ state.fixed_right_arg(), allocation_mode,
+ state.language_mode()));
}
if_rightisstring.End();
result = Pop();
@@ -1223,7 +1225,7 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
result = BuildBinaryOperation(
state.op(), left, right,
left_type, right_type, result_type,
- state.fixed_right_arg(), allocation_mode);
+ state.fixed_right_arg(), allocation_mode, state.language_mode());
}
// If we encounter a generic argument, the number conversion is
@@ -1257,7 +1259,8 @@ HValue* CodeStubGraphBuilder<BinaryOpWithAllocationSiteStub>::BuildCodeStub() {
return BuildBinaryOperation(state.op(), left, right,
left_type, right_type, result_type,
- state.fixed_right_arg(), allocation_mode);
+ state.fixed_right_arg(), allocation_mode,
+ state.language_mode());
}

Powered by Google App Engine
This is Rietveld 408576698