Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1109223003: chromeos: Increase WebUI font size to 80% for Roboto. (Closed)

Created:
5 years, 7 months ago by Daniel Erat
Modified:
5 years, 7 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Increase WebUI font size to 80% for Roboto. The IDS_WEB_FONT_SIZE resource specifies a percentage-based font size used in WebUI pages (e.g. settings or history). The previous value of 75% was appropriate for Noto Sans UI (the old default font), but Roboto (the default as of M42) is smaller. Increase the size to 80% so to make it more legible and to match the font used in the tab strip and in context menus. BUG=479731 Committed: https://crrev.com/9dc987a8aaae2534be49267c97459b04bd6cf837 Cr-Commit-Position: refs/heads/master@{#327564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/strings/app_locale_settings.grd View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Daniel Erat
5 years, 7 months ago (2015-04-28 22:20:38 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109223003/1
5 years, 7 months ago (2015-04-28 22:21:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 00:36:12 UTC) #6
xdai1
lgtm
5 years, 7 months ago (2015-04-29 17:05:13 UTC) #7
Daniel Erat
daisy mentioned that she had to update RenderTextTest.TextDoesntClip and OobeWebUITest for https://codereview.chromium.org/867403005/. i've verified that ...
5 years, 7 months ago (2015-04-29 20:25:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109223003/1
5 years, 7 months ago (2015-04-29 20:25:32 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-04-29 20:25:34 UTC) #12
xdai1
On 2015/04/29 20:25:34, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 7 months ago (2015-04-29 20:30:40 UTC) #13
Daniel Erat
5 years, 7 months ago (2015-04-29 20:32:01 UTC) #15
Albert Bodenhamer
lgtm
5 years, 7 months ago (2015-04-29 21:08:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109223003/1
5 years, 7 months ago (2015-04-29 21:10:06 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:33:08 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:34:32 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dc987a8aaae2534be49267c97459b04bd6cf837
Cr-Commit-Position: refs/heads/master@{#327564}

Powered by Google App Engine
This is Rietveld 408576698