Source/web/PopupContainer.cpp - Issue 1109213002: Make createWindow (mostly) work with OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupContainer.cpp

Issue 1109213002: Make createWindow (mostly) work with OOPIF (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix style, use FrameView::root Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/PopupContainer.cpp

diff --git a/Source/web/PopupContainer.cpp b/Source/web/PopupContainer.cpp

index 01bc2c8b875a85d107f1db65925528ee0034a094..49f536807da6043d1602322fb08dec49f2174413 100644

--- a/Source/web/PopupContainer.cpp

+++ b/Source/web/PopupContainer.cpp

@@ -200,7 +200,7 @@ IntRect PopupContainer::layoutAndCalculateWidgetRect(int targetControlHeight, co

IntRect widgetRectInScreen;

// If the popup would extend past the bottom of the screen, open upwards

// instead.

- IntRect screen = screenAvailableRect(m_frameView.get());

+ IntRect screen = m_frameView->root()->hostWindow() ? screenAvailableRect(*m_frameView->root()->hostWindow()) : IntRect();

// Use popupInitialCoordinate.x() + rightOffset because RTL position

// needs to be considered.

float pageScaleFactor = m_frameView->frame().page()->pageScaleFactor();