Source/core/page/CreateWindow.h - Issue 1109213002: Make createWindow (mostly) work with OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/CreateWindow.h

Issue 1109213002: Make createWindow (mostly) work with OOPIF (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix style, use FrameView::root Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/CreateWindow.h

diff --git a/Source/core/page/CreateWindow.h b/Source/core/page/CreateWindow.h

index bfee6db42fffa7e51efc80c9defcc34aebbbf3cc..eb52359ad6709d21d1f31e4cc916f38b998a1bd7 100644

--- a/Source/core/page/CreateWindow.h

+++ b/Source/core/page/CreateWindow.h

@@ -37,7 +37,7 @@ class LocalFrame;

struct FrameLoadRequest;

struct WindowFeatures;

-LocalFrame* createWindow(const String& urlString, const AtomicString& frameName, const WindowFeatures&,

+Frame* createWindow(const String& urlString, const AtomicString& frameName, const WindowFeatures&,

LocalDOMWindow& callingWindow, LocalFrame& firstFrame, LocalFrame& openerFrame);

void createWindowForRequest(const FrameLoadRequest&, LocalFrame& openerFrame, NavigationPolicy, ShouldSendReferrer);