Reland r12342: Flush monomorphic ICs on context disposal instead of context exit.

test/cctest/test-api.cc

Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 067d134b18650b44a56b5ddcd2338477da7ea802..09a08c415e9cac4a18e8966ede6e9082d70f1eb9 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -1,4 +1,5 @@
 // Copyright 2012 the V8 project authors. All rights reserved.
+

[Michael Starzinger, 2012/10/12 11:08:07]

That looks like a typo?

[ulan, 2012/10/12 12:23:09]

Done.

 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
@@ -10840,18 +10841,24 @@ TEST(DontLeakGlobalObjects) {
     { v8::HandleScope scope;
       LocalContext context;
     }
+    // Fire context disposed notification to force clearing monomorphic ICs.

[Michael Starzinger, 2012/10/12 11:08:07]

I think we can drop the comment, the method call itself should be
self-explanatory. Same for the rest of the function.

[ulan, 2012/10/12 12:23:09]

Done.

+    v8::V8::ContextDisposedNotification();
     CheckSurvivingGlobalObjectsCount(0);
 
     { v8::HandleScope scope;
       LocalContext context;
       v8_compile("Date")->Run();
     }
+    // Fire context disposed notification to force clearing monomorphic ICs.
+    v8::V8::ContextDisposedNotification();
     CheckSurvivingGlobalObjectsCount(0);
 
     { v8::HandleScope scope;
       LocalContext context;
       v8_compile("/aaa/")->Run();
     }
+    // Fire context disposed notification to force clearing monomorphic ICs.
+    v8::V8::ContextDisposedNotification();
     CheckSurvivingGlobalObjectsCount(0);
 
     { v8::HandleScope scope;
@@ -10860,6 +10867,8 @@ TEST(DontLeakGlobalObjects) {
       LocalContext context(&extensions);
       v8_compile("gc();")->Run();
     }
+    // Fire context disposed notification to force clearing monomorphic ICs.
+    v8::V8::ContextDisposedNotification();
     CheckSurvivingGlobalObjectsCount(0);
   }
 }
@@ -15006,6 +15015,7 @@ TEST(Regress528) {
     context->Exit();
   }
   context.Dispose();
+  v8::V8::ContextDisposedNotification();
   for (gc_count = 1; gc_count < 10; gc_count++) {
     other_context->Enter();
     CompileRun(source_exception);