Issue 11092075: HChange is only deletable under certain circumstances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11092075: HChange is only deletable under certain circumstances. (Closed)

Created:
8 years, 2 months ago by Sven Panne

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

HChange is only deletable under certain circumstances. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12702

Patch Set 2 : Broadened check #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/hydrogen-instructions.h	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://codereview.chromium.org/11092075/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/11092075/diff/1/src/hydrogen-instructions.h#newcode1296 src/hydrogen-instructions.h:1296: return !from().IsTagged() || (!to().IsDouble() && value()->type().IsSmi()); Why do we ...

8 years, 2 months ago (2012-10-11 13:48:43 UTC) #1

Sven Panne

Broadened check, PTAL... https://codereview.chromium.org/11092075/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/11092075/diff/1/src/hydrogen-instructions.h#newcode1296 src/hydrogen-instructions.h:1296: return !from().IsTagged() || (!to().IsDouble() && value()->type().IsSmi()); ...

8 years, 2 months ago (2012-10-11 14:11:49 UTC) #2

LGTM.

Expand Messages | Collapse Messages

Issue 11092075: HChange is only deletable under certain circumstances. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Broadened check #

Messages