Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 11092069: Fix PerfCountNotifier email notifier used by perf_av bot. (Closed)

Created:
8 years, 2 months ago by shadi
Modified:
8 years, 2 months ago
Reviewers:
cmp, shadi1
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Fix PerfCountNotifier (used by perf_av). BUG=155124 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163450

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -40 lines) Patch
M scripts/master/perf_count_notifier.py View 1 8 chunks +26 lines, -15 lines 0 comments Download
M scripts/master/unittests/perf_count_notifier_test.py View 1 11 chunks +83 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
shadi
cmp@ can you PTAL?
8 years, 2 months ago (2012-10-11 05:11:16 UTC) #1
shadi1
On 2012/10/11 05:11:16, shadi wrote: > cmp@ can you PTAL? ping! :-) PS: This change ...
8 years, 2 months ago (2012-10-16 00:34:37 UTC) #2
cmp
lgtm with nits https://codereview.chromium.org/11092069/diff/2001/scripts/master/perf_count_notifier.py File scripts/master/perf_count_notifier.py (right): https://codereview.chromium.org/11092069/diff/2001/scripts/master/perf_count_notifier.py#newcode75 scripts/master/perf_count_notifier.py:75: old_id.endswith(builder_name)] Since the conditional spans the ...
8 years, 2 months ago (2012-10-22 18:39:16 UTC) #3
shadi1
https://codereview.chromium.org/11092069/diff/2001/scripts/master/perf_count_notifier.py File scripts/master/perf_count_notifier.py (right): https://codereview.chromium.org/11092069/diff/2001/scripts/master/perf_count_notifier.py#newcode75 scripts/master/perf_count_notifier.py:75: old_id.endswith(builder_name)] On 2012/10/22 18:39:16, cmp wrote: > Since the ...
8 years, 2 months ago (2012-10-23 00:11:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/11092069/10001
8 years, 2 months ago (2012-10-23 00:11:30 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-23 00:13:19 UTC) #6
Change committed as 163450

Powered by Google App Engine
This is Rietveld 408576698