Teach BindToLoop to create callbacks that accept scoped parameters.

webkit/media/webmediaplayer_impl.cc

Index: webkit/media/webmediaplayer_impl.cc
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index b80b2ff9e96fdc15178b7424ef7011664767382f..9761043c68f1f41d4fc1e72ca3930c76646a357d 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -96,6 +96,10 @@ COMPILE_ASSERT_MATCHING_ENUM(UseCredentials);
   media::BindToLoop(main_loop_->message_loop_proxy(), base::Bind( \
       function, AsWeakPtr()))
 
+#define BIND_TO_RENDER_LOOP_2(function, arg1, arg2)                 \

[xhwang, 2012/10/23 21:37:03]

remove extra spaces?

[Ami GONE FROM CHROMIUM, 2012/10/23 21:58:07]

Done.

+  media::BindToLoop(main_loop_->message_loop_proxy(), base::Bind( \
+      function, AsWeakPtr(), arg1, arg2))
+
 static WebKit::WebTimeRanges ConvertToWebTimeRanges(
     const media::Ranges<base::TimeDelta>& ranges) {
   WebKit::WebTimeRanges result(ranges.size());
@@ -113,15 +117,6 @@ typedef base::Callback<void(const std::string&,
                             scoped_array<uint8>,
                             int)> OnNeedKeyCB;
 
-static void OnDemuxerNeedKeyTrampoline(
-    const scoped_refptr<base::MessageLoopProxy>& message_loop,
-    const OnNeedKeyCB& need_key_cb,
-    scoped_array<uint8> init_data,
-    int init_data_size) {
-  message_loop->PostTask(FROM_HERE, base::Bind(
-      need_key_cb, "", "", base::Passed(&init_data), init_data_size));
-}
-
 WebMediaPlayerImpl::WebMediaPlayerImpl(
     WebKit::WebFrame* frame,
     WebKit::WebMediaPlayerClient* client,
@@ -273,9 +268,7 @@ void WebMediaPlayerImpl::load(const WebKit::WebURL& url, CORSMode cors_mode) {
   if (!url.isEmpty() && url == GetClient()->sourceURL()) {
     chunk_demuxer_ = new media::ChunkDemuxer(
         BIND_TO_RENDER_LOOP(&WebMediaPlayerImpl::OnDemuxerOpened),
-        base::Bind(&OnDemuxerNeedKeyTrampoline,
-                   main_loop_->message_loop_proxy(),
-                   base::Bind(&WebMediaPlayerImpl::OnNeedKey, AsWeakPtr())));
+        BIND_TO_RENDER_LOOP_2(&WebMediaPlayerImpl::OnNeedKey, "", ""));

[xhwang, 2012/10/23 21:37:03]

Thanks for fixing this :)

 
     BuildMediaSourceCollection(chunk_demuxer_,
                                message_loop_factory_.get(),