Add Wallpaper option to launcher context menu

Add Wallpaper option to launcher context menu


BUG=143015
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161391

[Harry McCleave, 2012-10-10 00:09:13]

Would you mind taking a look at this when you get the chance.

[sky, 2012-10-10 04:07:17]

If we do this don't we need to update the descriptions to make it clear what
alignment/auto-hide is being changed?

https://codereview.chromium.org/11092034/diff/7001/ash/launcher/launcher.h
File ash/launcher/launcher.h (right):

https://codereview.chromium.org/11092034/diff/7001/ash/launcher/launcher.h#ne...
ash/launcher/launcher.h:87: // Show the context menu for the Launcher.
nit: newline between 87/88.

https://codereview.chromium.org/11092034/diff/7001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/11092034/diff/7001/ash/shell.cc#newcode522
ash/shell.cc:522: launcher()->ShowContextMenu(location);
NULL check this sine it can be NULL.

https://codereview.chromium.org/11092034/diff/7001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/11092034/diff/7001/ash/shell.h#newcode191
ash/shell.h:191: // Shows the context menu for the background and launcher at
|location|.
Document what location is relative to.

[Harry McCleave, 2012-10-10 22:51:34]

On 2012/10/10 04:07:17, sky wrote:
> If we do this don't we need to update the descriptions to make it clear what
> alignment/auto-hide is being changed?
> 
> https://codereview.chromium.org/11092034/diff/7001/ash/launcher/launcher.h
> File ash/launcher/launcher.h (right):
> 
>
https://codereview.chromium.org/11092034/diff/7001/ash/launcher/launcher.h#ne...
> ash/launcher/launcher.h:87: // Show the context menu for the Launcher.
> nit: newline between 87/88.
> 
> https://codereview.chromium.org/11092034/diff/7001/ash/shell.cc
> File ash/shell.cc (right):
> 
> https://codereview.chromium.org/11092034/diff/7001/ash/shell.cc#newcode522
> ash/shell.cc:522: launcher()->ShowContextMenu(location);
> NULL check this sine it can be NULL.
> 
> https://codereview.chromium.org/11092034/diff/7001/ash/shell.h
> File ash/shell.h (right):
> 
> https://codereview.chromium.org/11092034/diff/7001/ash/shell.h#newcode191
> ash/shell.h:191: // Shows the context menu for the background and launcher at
> |location|.
> Document what location is relative to.

Done, both strings mention launcher specifically "Autohide Launcher", "Launcher
Position", so I think we are ok on that front, or am I misunderstanding / who
should we run this by?

[sky, 2012-10-11 00:40:33]

LGTM - I didn't realize they already have launcher in the title.

[commit-bot: I haz the power, 2012-10-11 18:03:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/11092034/10001

[commit-bot: I haz the power, 2012-10-11 18:31:22]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-11 20:23:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/11092034/10001