Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 11092032: Fix chromium testshell crash on startup. (Closed)

Created:
8 years, 2 months ago by Yaron
Modified:
8 years, 2 months ago
Reviewers:
shashi, cjhopman, Lei Zhang
CC:
chromium-reviews, shashi
Visibility:
Public.

Description

Fix chromium testshell crash on startup. After http://codereview.chromium.org/10876056/, we need to include chrome's pak files in testshell. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/java_apk.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_android.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yaron
8 years, 2 months ago (2012-10-09 20:27:04 UTC) #1
shashi
lgtm
8 years, 2 months ago (2012-10-09 20:30:15 UTC) #2
cjhopman
lgtm
8 years, 2 months ago (2012-10-09 20:31:06 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 2 months ago (2012-10-09 20:33:40 UTC) #4
Yaron
+thestig for chrome/OWNERS and review
8 years, 2 months ago (2012-10-09 20:34:55 UTC) #5
Lei Zhang
lgtm
8 years, 2 months ago (2012-10-09 20:42:02 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-09 20:43:37 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698