Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1109203002: Revert of Pass -Oz flag to Clang when targeting Android. (Closed)

Created:
5 years, 7 months ago by pcc
Modified:
5 years, 7 months ago
Reviewers:
Nico, pcc1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass -Oz flag to Clang when targeting Android. (patchset #2 id:20001 of https://codereview.chromium.org/1103393002/) Reason for revert: Causes a build failure with -Dcomponent=shared_library Original issue's description: > Pass -Oz flag to Clang when targeting Android. > > The -Oz flag enables more aggressive size optimizations. Shrinks the > libchromeshell.so DSO by around 2.5MB. > > BUG=481675 > R=thakis@chromium.org > > Committed: https://crrev.com/2433e6ab2206fad3bc5954fd61e9d4785ccab108 > Cr-Commit-Position: refs/heads/master@{#327183} TBR=thakis@chromium.org,pcc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=481675 Committed: https://crrev.com/eddc3cebcf7e727968611c314d34593f7bb1a97d Cr-Commit-Position: refs/heads/master@{#327326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pcc
Created Revert of Pass -Oz flag to Clang when targeting Android.
5 years, 7 months ago (2015-04-28 18:09:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109203002/1
5 years, 7 months ago (2015-04-28 18:09:57 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-04-28 18:09:58 UTC) #4
Nico
lgtm
5 years, 7 months ago (2015-04-28 18:10:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109203002/1
5 years, 7 months ago (2015-04-28 18:11:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 18:12:56 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 18:13:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eddc3cebcf7e727968611c314d34593f7bb1a97d
Cr-Commit-Position: refs/heads/master@{#327326}

Powered by Google App Engine
This is Rietveld 408576698