Browser Plugin: Implement CanGoBack/CanGoForward

content/browser/browser_plugin/browser_plugin_host_browsertest.cc

Index: content/browser/browser_plugin/browser_plugin_host_browsertest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_host_browsertest.cc b/content/browser/browser_plugin/browser_plugin_host_browsertest.cc
index 28ab5b1fa0f31994a83b17081990ecaad16f0529..6f14aacf7872d51db6de46f740a2173340d544cb 100644
--- a/content/browser/browser_plugin/browser_plugin_host_browsertest.cc
+++ b/content/browser/browser_plugin/browser_plugin_host_browsertest.cc
@@ -539,6 +539,12 @@ IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, Renavigate) {
     content::TitleWatcher title_watcher(test_guest()->web_contents(),
                                         expected_title);
 
+    base::Value* value =
+        rvh->ExecuteJavascriptAndGetValue(string16(),
+                                          ASCIIToUTF16("CanGoBack()"));
+    bool result = false;
+    ASSERT_TRUE(value->GetAsBoolean(&result));
+    EXPECT_TRUE(result);

[Charlie Reis, 2012/10/10 06:06:53]

I think it would be clearer to move this check after the Back(), and also check
that CanGoForward() is true.  (Otherwise it reads strangely because the comment
above makes it sound like the back navigation has already happened.)

[Fady Samuel, 2012/10/10 17:36:44]

Done.

     rvh->ExecuteJavascriptAndGetValue(string16(), ASCIIToUTF16("Back();"));
 
     string16 actual_title = title_watcher.WaitAndGetTitle();
@@ -551,6 +557,12 @@ IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, Renavigate) {
     content::TitleWatcher title_watcher(test_guest()->web_contents(),
                                         expected_title);
 
+    base::Value* value =
+        rvh->ExecuteJavascriptAndGetValue(string16(),
+                                          ASCIIToUTF16("CanGoForward()"));
+    bool result = false;
+    ASSERT_TRUE(value->GetAsBoolean(&result));
+    EXPECT_TRUE(result);
     rvh->ExecuteJavascriptAndGetValue(string16(), ASCIIToUTF16("Forward();"));
 
     string16 actual_title = title_watcher.WaitAndGetTitle();
@@ -563,6 +575,12 @@ IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, Renavigate) {
     content::TitleWatcher title_watcher(test_guest()->web_contents(),
                                         expected_title);
 
+    base::Value* value =
+        rvh->ExecuteJavascriptAndGetValue(string16(),
+                                          ASCIIToUTF16("CanGoBack()"));
+    bool result = false;
+    ASSERT_TRUE(value->GetAsBoolean(&result));
+    EXPECT_TRUE(result);

[Charlie Reis, 2012/10/10 06:06:53]

Again, we should be testing cases when CanGoBack returns false (i.e., after the
Go(-2)).

[Fady Samuel, 2012/10/10 17:36:44]

Done.

     rvh->ExecuteJavascriptAndGetValue(string16(), ASCIIToUTF16("Go(-2);"));
 
     string16 actual_title = title_watcher.WaitAndGetTitle();